Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added distance.cpp for the SphericalDistanceDeterminationAlgorithm #4

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tan7271
Copy link

@tan7271 tan7271 commented May 2, 2024

Description

-Changed a few header files (namely attitude-utils) to add midpoint functions for Vec2 and Vec3
-Line 49 of Distance.cpp python code was center = np.linalg.solve(A, y), which i used the inverse matrix function to solve for instead.
(Probably contains a few errors, if you see them feel free to point out)

Artifacts for PR #4 (DO NOT CHANGE)

tan7271 added 2 commits May 1, 2024 22:30
-Changed a few header files (namely attitude-utils) to add midpoint functions for Vec2 and Vec3
Copy link
Collaborator

@nguy8tri nguy8tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just some changes before we test!

src/attitude-utils.cpp Outdated Show resolved Hide resolved
src/attitude-utils.cpp Outdated Show resolved Hide resolved
src/attitude-utils.cpp Outdated Show resolved Hide resolved
src/attitude-utils.hpp Outdated Show resolved Hide resolved
src/attitude-utils.hpp Outdated Show resolved Hide resolved
src/distance.cpp Outdated Show resolved Hide resolved
src/distance.hpp Outdated Show resolved Hide resolved
src/distance.hpp Outdated Show resolved Hide resolved
src/style.hpp Outdated Show resolved Hide resolved
src/attitude-utils.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@nguy8tri nguy8tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a few more styling issues!

src/attitude-utils.cpp Outdated Show resolved Hide resolved
src/distance.cpp Outdated Show resolved Hide resolved
src/distance.cpp Outdated Show resolved Hide resolved
src/distance.cpp Outdated Show resolved Hide resolved
commit 3863509
Author: Hieu Nguyen <[email protected]>
Date:   Mon Oct 14 12:11:23 2024 -0700

    Pipeline Implementation (#7)

    * Added return to main

    * Squashed commit of the following:

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Squashed commit of the following:

    commit 7b3c7e1
    Author: Tri Nguyen <[email protected]>
    Date:   Fri Sep 13 10:51:58 2024 -0700

        Refractoring Changes

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Merging from refractor

    * Pipeline Implementation

    * Made initial test and edits to pipeline.*

    * Use constants more

    * Squashed commit of the following:

    commit f370c67
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Sep 21 16:21:59 2024 -0700

        Refractor v2 (#6)

    commit 0a466d3
    Author: Tri Nguyen <[email protected]>
    Date:   Sun Sep 15 19:42:02 2024 -0700

        Refractor Code Base for Implementation (#5)

        Merge from pipeline, refractoring changes

        PR: #5

    commit 86a843f
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 17:24:22 2023 -0700

        Update README to viewable version

    commit 00a9764
    Merge: bc566cb 8eaa5cf
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Mar 25 16:37:50 2023 -0700

        Merge pull request #2 from UWCubeSat/interface

        Testing Suite Setup

    * Removed catch framework

    * Fixed minor issues

    * Documentation and Quality Changes

    * pending tests

    * pipeline tests 100% coverage, all functions work

    * Squashed commit of the following:

    commit 1d2c89b
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Oct 5 17:19:22 2024 -0700

        Example Test bugs

    commit adece2b
    Author: Tri Nguyen <[email protected]>
    Date:   Sat Oct 5 17:11:03 2024 -0700

        Stage extension for all stages

    * Revert to C++11

    * Resolving Changes

    ---------

    Co-authored-by: Tri Nguyen <[email protected]>

commit f370c67
Author: Tri Nguyen <[email protected]>
Date:   Sat Sep 21 16:21:59 2024 -0700

    Refractor v2 (#6)

commit 0a466d3
Author: Tri Nguyen <[email protected]>
Date:   Sun Sep 15 19:42:02 2024 -0700

    Refractor Code Base for Implementation (#5)

    Merge from pipeline, refractoring changes

    PR: #5

# Conflicts:
#	src/distance/distance.hpp
#	src/style/style.hpp
@nguy8tri
Copy link
Collaborator

nguy8tri commented Oct 17, 2024

Just merged from main into this branch (took about an hour, you're welcome). Here's what else I've done:

  1. Took out some unnecessary code (e.g. A function who only calls another function)
  2. Added Documentation to Undocumented Stuff
  3. Placed your files in the appropriate folder (src/distance and test/distance)
  4. I also did some light debugging of your code, and it turns out the math behind some of your original code was wrong, so I fixed that, and your base case test does work now (hooray!).

I'm not sure if you saw the new message, but there are quite a few changes that have occurred with the code base. This is part of a modern refractor to leverage CI/CD in our project.

  • A detailed documentation of the new changes can be viewed here
  • Our meeting on 10/14 is recorded, in which I go over all these changes. You can access the recording here)
    These changes automate many parts of the coding process. This includes the PRs that you publish, which have automated checks. The bottom line is that if your checks are not passing, then you need to fix it before I review it (you can verify if it will do so locally by simply specifying make). Luckily, I made sure of that to begin with, so you're starting off with them passing! They will update every time you make a new commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants