Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on location of manual motion script #130

Open
bsaund opened this issue Jan 12, 2021 · 9 comments
Open

Decide on location of manual motion script #130

bsaund opened this issue Jan 12, 2021 · 9 comments

Comments

@bsaund
Copy link
Contributor

bsaund commented Jan 12, 2021

Currently manual_motion is duplicated in KHI and arm_robots.

manual_motion does not require arm_robots code, which was more important with the openrave dependency of arm_or_robots. With the open_rave dependency dropped, we can migrate everything to arm_robots to keep all victor motion scripts in the same place

@PeterMitrano
Copy link
Contributor

I think I prefer it being in KHI if it doesn't need/use arm_robots

@PeterMitrano
Copy link
Contributor

but I guess it depends on what you mean by "everything"?

@bsaund
Copy link
Contributor Author

bsaund commented Jan 12, 2021

I misspoke. I just mean migrating manual_motion.

@PeterMitrano
Copy link
Contributor

I'd say it makes more sense in VHI (I can never keep these names straight), since it's specific to that code

@bsaund
Copy link
Contributor Author

bsaund commented Jan 12, 2021

The VHI version will need to be fixed to work with the other changes we've made to KHI. I think some namespaces have changed.

@PeterMitrano
Copy link
Contributor

I think someone has used manual motion recently @powertj @LemonPi @mvandermerwe which version did you use?

@bsaund
Copy link
Contributor Author

bsaund commented Jan 12, 2021

Over winter break the arm_robots version worked, the KHI one did not.

@mvandermerwe
Copy link

I did not use manual motion recently.

@PeterMitrano
Copy link
Contributor

in that case I'd say move the arm_robots version to VHI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants