-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on location of manual motion script #130
Comments
I think I prefer it being in KHI if it doesn't need/use arm_robots |
but I guess it depends on what you mean by "everything"? |
I misspoke. I just mean migrating |
I'd say it makes more sense in VHI (I can never keep these names straight), since it's specific to that code |
The VHI version will need to be fixed to work with the other changes we've made to KHI. I think some namespaces have changed. |
I think someone has used manual motion recently @powertj @LemonPi @mvandermerwe which version did you use? |
Over winter break the |
I did not use manual motion recently. |
in that case I'd say move the arm_robots version to VHI |
Currently
manual_motion
is duplicated in KHI andarm_robots
.manual_motion
does not requirearm_robots
code, which was more important with the openrave dependency ofarm_or_robots
. With the open_rave dependency dropped, we can migrate everything toarm_robots
to keep all victor motion scripts in the same placeThe text was updated successfully, but these errors were encountered: