Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic search functionality #139

Conversation

crhistianramirez
Copy link
Contributor

@crhistianramirez crhistianramirez commented Jun 7, 2020

What

Adds basic search functionality.

Why

Helps users find locations they're interested more easily

Resolves part of #127

Ensure the following interactions work as expected. Please test using a mobile form factor.

  • Tapping on a marker on the map displays information about the marker in a popup.
  • Tapping the "Show list of locations" button replaces the map view with a list view.
  • Tapping an item in the list replaces the list view with a map view, and navigates the map to the tapped item on the map.
  • Tapping one of the ✅'s in the legend filters items on the map and in the list.
  • Changing the language to spanish changes things on the page.
  • Clicking the Help/Info button opens and closes a menu with information.
  • Clicking the X Close button on the Help/Info screen closes the modal.

Check the app in the following web browsers:

  • Chrome
  • Firefox
  • Edge
  • Safari

@jdalt
Copy link
Contributor

jdalt commented Jun 8, 2020

@crhistianramirez @laniehei
Correct me if I'm wrong, but I think #138 and #139 are out of order. It seems that #139 adds the base feature and #138 is a usability enhancement to it.

I also think we might want to avoid basing branches off of each other in Pull Requests since it breaks the QA cycle - I think we only get Netlify builds when the base branch is master. If we have to base branches off of each other, maybe we can label them "Blocked" but base them off of master?

Thank you for your continued contributions! This is one of most important missing features in the app.

@crhistianramirez
Copy link
Contributor Author

@jdalt roger that. I'll close this one and make a new pr to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants