Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds link and modal to the search help #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

laniehei
Copy link

@laniehei laniehei commented Jun 7, 2020

What

This adds a link to pop up a modal to help instruct on the new search feature.

Why

This addresses part of issue #127

Ensure the following interactions work as expected. Please test using a mobile form factor.

  • Tapping on a marker on the map displays information about the marker in a popup.
  • Tapping the "Show list of locations" button replaces the map view with a list view.
  • Tapping an item in the list replaces the list view with a map view, and navigates the map to the tapped item on the map.
  • Tapping one of the ✅'s in the legend filters items on the map and in the list.
  • Changing the language to spanish changes things on the page.
  • Clicking the X Close button on the Help/Info screen closes the modal.
  • Clicking the search help link opens and closes a menu with information.
  • Clicking the X Close button on the search help screen closes the modal.

Check the app in the following web browsers:

  • Chrome
  • Firefox
  • Edge
  • Safari

Additional Notes

Does not have the new search code included. Do not merge without the search code.

@crhistianramirez
Copy link
Contributor

Thank you very much!! <3

I think we might want to merge my search functionality stuff into this branch before this PR gets merged so that it gets deployed all at once.

I made a PR to this branch here: #139

@jdalt jdalt mentioned this pull request Jun 8, 2020
11 tasks
Copy link
Contributor

@jdalt jdalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I don't have any complaints about the code, but I think the content of the modal needs to be reviewed by some TCMAP folks and the usefulness of the advice needs to be validated in QA.

<li class='txt-small search-example' data-translation-id=""><b>Zip Code</b> - e.g. '55108'</li>
<li class='txt-small search-example' data-translation-id=""><b>City Name </b> - e.g. 'St. Paul'</li>
<li class='txt-small search-example' data-translation-id=""><b>Item</b> - e.g. 'food', 'water', or 'toiletries'</li>
<li class='txt-small search-example' data-translation-id=""><b>Building Type</b> - e.g. 'church', or 'shelter'</li>
Copy link
Contributor

@jdalt jdalt Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the UI mockup and state of the data are somewhat disconnected:

  • We don't currently capture "Building Type" anywhere in the Google Sheet. There might be fragments of this in the notes, but I don't think this should be advertised as feature of the search.
  • I think "Neighborhood" might be more useful to search for than "City" (debatable)
  • I'm not certain what "Item" refers to in the data. Is this something in the needs section?
  • I don't believe we capture Language Criteria in the Google Sheets.

I think we need to take a step back and make certain that someone on the TCMAP side verifies these, and we try out each of these search criteria and validate that they return useful information.

Copy link
Contributor

@comeoneileen comeoneileen Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm sort of the defacto head of the data entry crew and haven't done a good job chiming in on the Github side of things yet. Hello. We are SO excited about the prospect of search, even if it were nothing more than a mobile-friendly version of opening the spreadsheet and doing a ctrl-F, and it looks like y'all have some great stuff in the works.

@jdalt, you're entirely correct about "building type" - it crossed my mind today as not a terrible idea to capture eventually, but I'd like to hear more from map users about how difficult sites are to find. My understanding is that many are NOT buildings - a lot of this is tents in parking lots, card tables on lawns, etc.

We...do have a column for neighborhood at the moment and not city (city does exist as part of the address), but...I'm not convinced that neighborhood info we have is (A) accurate or (B) being used for anything anyway.

I just realized how late it is and need to stop there, but if anybody wants to do the official data entry volunteer training and REALLY get a close look at the process, it'll be 6/9 from 19:00-20:30 or so. I'd also be open to running an abbreviated version with folks working specifically on this feature. I'm on OTC Slack as Eileen King.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey peeps-
I was thinking and curious if you guys feel the same way about this, but I kind of wonder now if we actually don't need to include a search example modal/pop up window.

It was more of a starting point to provide any help or context but I'm wondering how useful it is now that I'm thinking more on it. I suppose it could help if there are common questions on things but didn't want to feel like we needed to add it if it's unnecessary confusion?

Let me know what you guys think!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being that the search isn't as full-featured as, say, google, and folks don't know the parameters they can search, I feel that it would still be nice to add. But I also might be admittedly biased because I spent several hours hacking this out 😅 would like others to weigh in

Copy link
Contributor

@codarose codarose Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all! Sorry to be so late in weighing in on this, didn't mean to leave you hanging for so long Lanie!

@laniehei I really appreciate the work you did on this! I think an issue we are facing is that our UI design got ahead of our actual user-driven needs. I think before we add something like this to the design, we need to get user feedback to determine if it is actually needed, and if so, what would make it the most helpful. We are stuck right now at this "user feedback" issue, in that we currently have no good way of getting that feedback unfortunately. So that has made it difficult to weigh in on this design change.

I'm inclined to agree that explaining that this is an exact search, and not as robust as say google search, could be helpful. But this is also something that takes up real-estate in a fixed part of the screen, and we are currently having conversations about the UI design in general to determine if other things need to be prioritized into that space, such as the 'search' bar itself, which currently is lost when users scroll through locations.

I think we need to table this design direction for now until we've gotten more feedback.

Again thank you for this work, and sorry this process ended up being so messy - we need to find a more clear way of presenting UI changes so that they are motivated by an understanding of the data, or from user feedback.

@crhistianramirez
Copy link
Contributor

Blocked until this PR is merged #144

@crhistianramirez
Copy link
Contributor

This is no longer blocked as #156 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Clarification Status: Needs Master Merge This Pull Request needs recent changes merged in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants