Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change] BEP Redis key format #1345

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Change] BEP Redis key format #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nativelink-service/src/bep_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ impl BepServer {
self.store
.update_oneshot(
StoreKey::Str(Cow::Owned(format!(
"LifecycleEvent-{}-{}-{}",
"LifecycleEvent:{}:{}:{}",
&stream_id.build_id, &stream_id.invocation_id, sequence_number,
))),
buf.freeze(),
Expand Down Expand Up @@ -114,7 +114,7 @@ impl BepServer {
store
.update_oneshot(
StoreKey::Str(Cow::Owned(format!(
"BuildToolEventStream-{}-{}-{}",
"BuildToolEventStream:{}:{}:{}",
&stream_id.build_id, &stream_id.invocation_id, sequence_number,
))),
buf.freeze(),
Expand Down
4 changes: 2 additions & 2 deletions nativelink-service/tests/bep_server_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async fn publish_lifecycle_event_test() -> Result<(), Box<dyn std::error::Error>
let sequence_number = request.clone().build_event.unwrap().sequence_number;

let store_key = StoreKey::Str(Cow::Owned(format!(
"LifecycleEvent-{}-{}-{}",
"LifecycleEvent:{}:{}:{}",
stream_id.clone().build_id,
stream_id.clone().invocation_id,
sequence_number
Expand Down Expand Up @@ -280,7 +280,7 @@ async fn publish_build_tool_event_stream_test() -> Result<(), Box<dyn std::error
.iter()
.map(|request| {
StoreKey::Str(Cow::Owned(format!(
"BuildToolEventStream-{}-{}-{}",
"BuildToolEventStream:{}:{}:{}",
stream_id.build_id,
stream_id.invocation_id,
request
Expand Down