[Change] BEP Redis key format #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchahinRohani
had a problem deploying
to
production
GitHub Actions
Failure
":" is the preferred way since Redis Insight from Redis itself shows your keys inside directories with ":".
SchahinRohani
force-pushed
the
update/redis-key-format
branch
from
136503a to
d5f87ba
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
allada
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, Remote / large-ubuntu-22.04, windows-2022 / stable
allada
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, Remote / large-ubuntu-22.04, windows-2022 / stable (waiting on @adam-singer)
adam-singer
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 2 LGTMs obtained, and all files reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
":" is the preferred way since Redis Insight from Redis itself shows your keys inside directories with ":"
This might break existing client setups which rely on the bep events.
Type of change
not work as expected)
How Has This Been Tested?
Used bazel with the bep_backend to inspect the delivered bep keys in redis.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is