-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(socketio/ns): store ns path and rooms as Cow<'static, str>
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
changed the title
feat(socketio/ns): store ns path as
feat(socketio/ns): store ns path and rooms as Oct 21, 2023
Cow<'static, str>
Cow<'static, str>
This reverts commit eb20f85.
Benchmark results: benchmark-feat-cow-namespaces-and-rooms.zip |
One of the remaining things that won't be improved in this PR is the "int to string" conversion. It is currently using One of the solution was to use this function, however it inserts digits in reverse order: fn insert_number(mut v: usize, res: &mut String) {
debug_assert!(v > 0);
while v > 0 {
let n = (v % 10) as u8;
v /= 10;
res.push((n + 0x30) as char);
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store ns path and rooms as
Cow<'static, str>
:String
toCow
LocalAdapter
fromString
toCow
Socket
fromString
toCow
String
buffer with asize_hint
function when encoding to avoid string reallocationsPackets
from bytes slice rather than String to avoidChar
iterators (removes deps itertools)