Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the itoa crate for packet encoding #143

Closed
Totodore opened this issue Nov 8, 2023 · 0 comments · Fixed by #161
Closed

Use the itoa crate for packet encoding #143

Totodore opened this issue Nov 8, 2023 · 0 comments · Fixed by #161
Assignees
@Totodore

Comments

@Totodore
Copy link
Owner

Totodore commented Nov 8, 2023

Currently integer data is encoded in string packet with the to_string() method which allocates and is really slow. Using the itoa crate would allow to avoid allocations and slowness.

Related to #124 (comment)
@Totodore Totodore self-assigned this Nov 8, 2023
@Totodore Totodore added this to Roadmap Nov 8, 2023
@Totodore Totodore moved this to Todo in Roadmap Nov 12, 2023
@Totodore Totodore mentioned this issue Nov 13, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Totodore Totodore

Labels
None yet
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

socket.io packet encoding with itoa Totodore/socketioxide
1 participant
@Totodore