Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set min sdk version to 24 (Android 7). #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

chore: Set min sdk version to 24 (Android 7).

b8330a4
Select commit
Loading
Failed to load commit list.
Open

chore: Set min sdk version to 24 (Android 7). #173

chore: Set min sdk version to 24 (Android 7).
b8330a4
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 1, 2024 in 0s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : chore: Set min sdk version to 24 (Android 7).
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : chore: Set min sdk version to 24 (Android 7).
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : See #172 by @ljgdasfhk.

This should make the APK work on older Android versions. In the android builder image, we already select API 23, so this should work.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}