Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set min sdk version to 24 (Android 7). #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 30, 2024

See #172 by @ljgdasfhk.

This should make the APK work on older Android versions. In the android builder image, we already select API 23, so this should work.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 30, 2024
@github-actions github-actions bot added the chore Updating grunt tasks etc; no production code change label Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.05%. Comparing base (df5edbf) to head (96d1dde).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   11.05%   11.05%           
=======================================
  Files         292      292           
  Lines       21227    21227           
=======================================
  Hits         2347     2347           
  Misses      18880    18880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant