Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue/feature/reference gh #981

Merged
merged 43 commits into from
Jan 23, 2024
Merged

Continue/feature/reference gh #981

merged 43 commits into from
Jan 23, 2024

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Dec 10, 2023 •
edited
Loading

For earlier context related to PR #966

continuing #599

Note: This merge will require Config to be changed on vps as well, otherwise bot crashes.

brief:

  • adds /github-search, which auto suggests a list of issues and PR to choose. It also accepts a title if you want to manually enter and select.
  • if a new message is of type #IssueNumberHere, it will reply back with an embed containing information about issue.
  • This is currently set to channel #general using config, can be tweaked to a particular channel.
  • More repositoriy Id's can be added to config to allow searching across multiple repositories.

Changes:

  • resolve merge conflicts
  • Java doc fixes
  • add avatar of user to embed
  • add date of creation to footer of embed
  • refactor embed builder for response

Embed on search/issue reference:

image

Tais993 and others added 30 commits September 30, 2022 23:48
@Tais993
Bugfix
490ec6f 
In BotCore:
Added onCommandAutoCompleteInteraction listener, this way autocompletion events will actually get forwarded.

Funny, didnt think of this during the previous PR, was probably too hasty.
@Tais993 @Taz03
Update application/src/main/java/org/togetherjava/tjbot/commands/syst…
aa58c07 
…em/BotCore.java

Co-authored-by: Tanish Azad <[email protected]>
@Taz03
fixed debug message
5f574d3
@illuminator3
add github referencing + github command
a9fef62
@illuminator3
make codeql and sonarcloud happy
9de6564
@illuminator3
spotless, *sigh*
1af1b54
@illuminator3
forgot these two
4325805
@illuminator3
remove mention when reference
d45db55
@illuminator3
aaaaaaaaaa
99ce678
@illuminator3
Merge branch 'develop' into feature/reference-gh
cad10d2
@illuminator3
fix compilation
a85abc2
@illuminator3
fix compilation x2
ef9989e
@illuminator3
apply spotless
1ba1418
@illuminator3
fix doc
3db6cfa
@illuminator3
requested changes
62b728d
@illuminator3
requested changes
3d2e48c
@illuminator3
requested changes
4c40202
@illuminator3 @Taz03
Update application/config.json.template
d98b829 
Co-authored-by: Tanish Azad <[email protected]>
@illuminator3 @Taz03
Update application/src/main/java/org/togetherjava/tjbot/commands/gith…
099f250 
…ub/GitHubCommand.java

Co-authored-by: Tanish Azad <[email protected]>
@illuminator3 @Taz03
Update application/src/main/java/org/togetherjava/tjbot/commands/gith…
b93dd7e 
…ub/GitHubReference.java

Co-authored-by: Tanish Azad <[email protected]>
@ankitsmt211
resolve conflicts
c7a8773
@ankitsmt211
Merge branch 'develop' into continue/feature/reference-gh
d780f41
@ankitsmt211
sonar fix
39bc9b2
@ankitsmt211
adding back suspicousKeywords
eb930b8
@ankitsmt211
requested changes in old PR
10414c6
@ankitsmt211
java doc fixes
92fdef4
@ankitsmt211
avatar of author in embed
4fafdb0
@ankitsmt211
refactor embed reply for clarity, add date of creation
c8afcb3
@ankitsmt211
sonar fix
5cbdfc9
@ankitsmt211
refactor date to a better format
2d9b54a
Taz03
Taz03 previously approved these changes Jan 14, 2024
View reviewed changes
@SquidXTV SquidXTV self-requested a review January 14, 2024 19:15
@ankitsmt211 ankitsmt211 requested review from SquidXTV and Taz03 January 18, 2024 05:17
SquidXTV
SquidXTV previously approved these changes Jan 18, 2024
View reviewed changes
Taz03
Taz03 previously approved these changes Jan 18, 2024
View reviewed changes
@ankitsmt211 ankitsmt211 dismissed stale reviews from Taz03 and SquidXTV January 20, 2024 08:02

need a couple more changes

@marko-radosavljevic
Copy link
Contributor

Haha, you didn't need to dismiss 2 passing reviews just to add repos to the template, it's just a template anyway. ^^

No worries tho, I will count them as passing. ❤️

@ankitsmt211
Copy link
Member Author

Haha, you didn't need to dismiss 2 passing reviews just to add repos to the template, it's just a template anyway. ^^

No worries tho, I will count them as passing. ❤️

apologies if that comes off as rude, but i didnt want someone to merge it(it was one click away ) by any chance since the results were inconsistent with when parallel stream was swapped with sequential, also the config changes ofc. It's better to fix issues when it's already active then making a new PR😉.

@ankitsmt211
changes to find issue method
d9f75c8 
* for github search, instead of finding by issue we also wanna match title for correct match
* method overloading for defaulting to tj-bot repo for reference feature
@ankitsmt211
sonar and better var name
4d01ccd
@ankitsmt211
sonar fix
f2d4c43
@ankitsmt211 ankitsmt211 requested review from SquidXTV and Taz03 January 21, 2024 21:23
@Zabuzard
Copy link
Member

im ready to merge it, but theres still one open conversation @ankitsmt211

@ankitsmt211
Copy link
Member Author

im ready to merge it, but theres still one open conversation @ankitsmt211

Go ahead, marked it resolved.

@Zabuzard Zabuzard merged commit c63add7 into Together-Java:develop Jan 23, 2024
9 checks passed
@ankitsmt211 ankitsmt211 deleted the continue/feature/reference-gh branch January 23, 2024 10:25
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 2, 2024
Closed
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SquidXTV SquidXTV SquidXTV approved these changes

@Zabuzard Zabuzard Zabuzard approved these changes

@Taz03 Taz03 Awaiting requested review from Taz03

Assignees

@ankitsmt211 ankitsmt211

Labels
enhancement New feature or request new command Add a new command or group of commands to the bot priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ankitsmt211 @marko-radosavljevic @Zabuzard @Taz03 @SquidXTV @Tais993 @illuminator3