GitHub Referencing & GitHub Command #599

illuminator3 · 2022-10-02T21:40:04Z

changes `gistApiKey` to `githubApiKey` in the config

In BotCore: Added onCommandAutoCompleteInteraction listener, this way autocompletion events will actually get forwarded. Funny, didnt think of this during the previous PR, was probably too hasty.

…em/BotCore.java Co-authored-by: Tanish Azad <[email protected]>

Tais993 · 2022-10-02T21:40:52Z

I LOVE YOU ILLU

Taz03 · 2022-10-02T21:44:37Z

what about not having the ping when the bot replies back?

illuminator3 · 2022-10-02T21:47:01Z

what about not having the ping when the bot replies back?

why?

Taz03 · 2022-10-02T21:52:03Z

why?

coz its a bot reply

illuminator3 · 2022-10-02T21:52:24Z

why?

coz its a bot reply

@Tais993 what do you think?

Tais993 · 2022-10-02T21:53:20Z

Don't have an opinion, either is fine to me

illuminator3 · 2022-10-02T21:54:40Z

I'll remove it since the command usage also has no ping I guess

application/config.json.template

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

Zabuzard · 2022-10-04T08:20:23Z

changes gistApiKey to githubApiKey in the config

note that this requires that people update their api key settings. gonna mention that when merging this.

Zabuzard · 2022-10-05T07:42:55Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

+        if (title.isEmpty()) {
+            event.replyChoiceStrings(autocompleteCache.stream().limit(25).toList()).queue();
+        } else {
+            Queue<String> queue = new PriorityQueue<>(Comparator.comparingInt(


the name isnt really optimal. maybe closestMatches or closestSuggestions.

it also reads a bit complex since u nested everything. i would at least move out the 25-list into a variable:

Queue<String> closestMatches = ... List<String> suggestions = ... event.replyChoiceStrings(suggestions).queue();

maybe also the logic u use to compute the score. So that its Comparator.comparingInt(this::scoreSuggestion) or similar.

could u also move the Stream.generate(closestSuggestions::poll).limit(25).toList() into its own variable? Its a bit harder to read when its all packed together with the JDA stuff of message-sending.

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

Zabuzard · 2022-10-05T07:46:57Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

+     */
+    private List<GHRepository> repositories;
+
+    public GitHubReference(Config config) {


better, yes. but i still have problems with the term "reference" for this (see other discussion). maybe we can find a better word that has less confusion potential

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

Zabuzard · 2022-10-05T07:51:51Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

+    }
+
+    /**
+     * Looks through all of the given repositories for an issue/pr with the given id


missing dot

seems u forgot to push this one

application/config.json.template

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

Taz03 · 2022-10-06T21:06:29Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

+        String title = event.getOption(TITLE_OPTION).getAsString();
+
+        if (title.isEmpty()) {
+            event.replyChoiceStrings(autocompleteGHIssueCache.stream().limit(25).toList()).queue();


don't use the magic number 25 use OptionData#MAX_CHOICES instead

Taz03 · 2022-10-06T21:07:20Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

+
+            closestSuggestions.addAll(autocompleteGHIssueCache);
+
+            event.replyChoiceStrings(Stream.generate(closestSuggestions::poll).limit(25).toList())


don't use the magic number 25 use OptionData#MAX_CHOICES instead

Co-authored-by: Tanish Azad <[email protected]>

…ub/GitHubCommand.java Co-authored-by: Tanish Azad <[email protected]>

…ub/GitHubReference.java Co-authored-by: Tanish Azad <[email protected]>

sonarqubecloud · 2022-10-06T22:38:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Zabuzard · 2022-10-07T07:01:29Z

application/config.json.template

+    "helpSystem": {
+        "stagingChannelPattern": "ask_here",
+        "overviewChannelPattern": "active_questions",
+            "categories": [


the indent for categories is one level too much

Zabuzard · 2022-10-07T07:05:37Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

+            event
+                .replyChoiceStrings(autocompleteCache.stream()
+                    .sorted(Comparator.comparingInt(s -> StringDistances.editDistance(title,
+                            s.replaceFirst("\\[\\d+] ", ""))))


the method is good, thanks for that. but i would still like to have a small comment on the regex. like // Remove the ID [#123] and then match

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

Zabuzard · 2022-10-07T07:08:25Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubCommand.java

+        if (title.isEmpty()) {
+            event.replyChoiceStrings(autocompleteCache.stream().limit(25).toList()).queue();
+        } else {
+            Queue<String> queue = new PriorityQueue<>(Comparator.comparingInt(


could u also move the Stream.generate(closestSuggestions::poll).limit(25).toList() into its own variable? Its a bit harder to read when its all packed together with the JDA stuff of message-sending.

Zabuzard · 2022-10-07T07:09:39Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

+    protected static final Pattern ISSUE_REFERENCE_PATTERN = Pattern.compile("#(?<id>\\d+)");
+    protected static final String ID_GROUP = "id";


gotta use the ID_GROUP in ur pattern as well. "#(?<%s>\\d+".formatted(ID_GROUP)

Zabuzard · 2022-10-07T07:10:27Z

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java

+    }
+
+    /**
+     * Looks through all of the given repositories for an issue/pr with the given id


seems u forgot to push this one

java-coding-prodigy · 2023-10-03T10:07:41Z

One year anniversary of this PR 🎉
Also are we going to this or should it be closed?

ankitsmt211 · 2024-03-02T09:50:01Z

#981 which continued work of this PR already merged.

Tais993 and others added 4 commits September 30, 2022 23:48

Bugfix

490ec6f

In BotCore: Added onCommandAutoCompleteInteraction listener, this way autocompletion events will actually get forwarded. Funny, didnt think of this during the previous PR, was probably too hasty.

Update application/src/main/java/org/togetherjava/tjbot/commands/syst…

aa58c07

…em/BotCore.java Co-authored-by: Tanish Azad <[email protected]>

fixed debug message

5f574d3

add github referencing + github command

a9fef62

illuminator3 requested review from a team as code owners October 2, 2022 21:40

make codeql and sonarcloud happy

9de6564

spotless, *sigh*

1af1b54

forgot these two

4325805

illuminator3 added 2 commits October 2, 2022 23:55

remove mention when reference

d45db55

aaaaaaaaaa

99ce678

Tais993 reviewed Oct 2, 2022

View reviewed changes

application/config.json.template Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/commands/github/GitHubReference.java Outdated Show resolved Hide resolved

illuminator3 requested review from marko-radosavljevic and Zabuzard October 3, 2022 12:23

illuminator3 self-assigned this Oct 3, 2022

illuminator3 added enhancement New feature or request priority: low valid This issue/PR is validated and ready to be picked. This auto adds items to TJ project board. labels Oct 3, 2022

illuminator3 added 4 commits October 4, 2022 12:56

Merge branch 'develop' into feature/reference-gh

cad10d2

fix compilation

a85abc2

fix compilation x2

ef9989e

apply spotless

1ba1418

requested changes

3d2e48c

Zabuzard reviewed Oct 5, 2022

View reviewed changes

Zabuzard requested changes Oct 5, 2022

View reviewed changes

requested changes

4c40202

Taz03 reviewed Oct 6, 2022

View reviewed changes

application/config.json.template Outdated Show resolved Hide resolved

Taz03 requested changes Oct 6, 2022

View reviewed changes

illuminator3 and others added 3 commits October 7, 2022 00:35

Update application/config.json.template

d98b829

Co-authored-by: Tanish Azad <[email protected]>

Update application/src/main/java/org/togetherjava/tjbot/commands/gith…

099f250

…ub/GitHubCommand.java Co-authored-by: Tanish Azad <[email protected]>

Update application/src/main/java/org/togetherjava/tjbot/commands/gith…

b93dd7e

…ub/GitHubReference.java Co-authored-by: Tanish Azad <[email protected]>

Zabuzard reviewed Oct 7, 2022

View reviewed changes

illuminator3 assigned Tais993 Nov 26, 2022

Zabuzard force-pushed the develop branch from 3fecdae to ec8f08c Compare December 12, 2022 14:08

Zabuzard added stale and removed valid This issue/PR is validated and ready to be picked. This auto adds items to TJ project board. labels Mar 6, 2023

github-actions bot added the inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later label Mar 12, 2023

github-actions bot closed this Mar 12, 2023

illuminator3 added valid This issue/PR is validated and ready to be picked. This auto adds items to TJ project board. and removed inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later labels Mar 12, 2023

illuminator3 reopened this Mar 12, 2023

github-actions bot removed the stale label Mar 13, 2023

Taz03 self-assigned this Mar 16, 2023

Taz03 assigned ankitsmt211 Nov 24, 2023

ankitsmt211 mentioned this pull request Nov 24, 2023

Continue/feature/reference gh #966

Closed

ankitsmt211 mentioned this pull request Dec 10, 2023

Continue/feature/reference gh #981

Merged

ankitsmt211 closed this Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Referencing & GitHub Command #599

GitHub Referencing & GitHub Command #599

illuminator3 commented Oct 2, 2022 •

edited

Loading

Tais993 commented Oct 2, 2022

Taz03 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Taz03 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Tais993 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Zabuzard commented Oct 4, 2022

Zabuzard Oct 5, 2022

illuminator3 Oct 6, 2022

Zabuzard Oct 7, 2022

Zabuzard Oct 5, 2022

Zabuzard Oct 5, 2022

illuminator3 Oct 6, 2022

Zabuzard Oct 7, 2022

Taz03 Oct 6, 2022

Taz03 Oct 6, 2022

sonarqubecloud bot commented Oct 6, 2022

Zabuzard Oct 7, 2022 •

edited

Loading

Zabuzard Oct 7, 2022

Zabuzard Oct 7, 2022

Zabuzard Oct 7, 2022

Zabuzard Oct 7, 2022

java-coding-prodigy commented Oct 3, 2023

ankitsmt211 commented Mar 2, 2024


		closestSuggestions.addAll(autocompleteGHIssueCache);

		event.replyChoiceStrings(Stream.generate(closestSuggestions::poll).limit(25).toList())

		protected static final Pattern ISSUE_REFERENCE_PATTERN = Pattern.compile("#(?<id>\\d+)");
		protected static final String ID_GROUP = "id";

GitHub Referencing & GitHub Command #599

GitHub Referencing & GitHub Command #599

Conversation

illuminator3 commented Oct 2, 2022 • edited Loading

changes gistApiKey to githubApiKey in the config

Tais993 commented Oct 2, 2022

Taz03 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Taz03 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Tais993 commented Oct 2, 2022

illuminator3 commented Oct 2, 2022

Zabuzard commented Oct 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 6, 2022

Zabuzard Oct 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

java-coding-prodigy commented Oct 3, 2023

ankitsmt211 commented Mar 2, 2024

illuminator3 commented Oct 2, 2022 •

edited

Loading

changes `gistApiKey` to `githubApiKey` in the config

Zabuzard Oct 7, 2022 •

edited

Loading