Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-2018] Replace email attachments with links to S3 on time tracking… #2214

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

dbernstein
Copy link
Contributor

@dbernstein dbernstein commented Dec 17, 2024

… reports.

Description

As the title says, we are using S3 to store the reports and sending the user a link that will perish in 30 days. There is a PR in hosting-playbook to ensure that all keys in public buckets with a cm_reports/ prefix expire in 30 days.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-2018

How Has This Been Tested?

Covered by unit tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (ff63d23) to head (c14aa22).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2214   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         363      363           
  Lines       41274    41282    +8     
  Branches     8837     8837           
=======================================
+ Hits        37606    37614    +8     
  Misses       2406     2406           
  Partials     1262     1262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other then updating the prefix to match

@dbernstein dbernstein merged commit 44008e2 into main Dec 18, 2024
21 checks passed
@dbernstein dbernstein deleted the PP-2018-add-links-to-audiobook-timetracking branch December 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants