Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check collection.py (PP-503) #1481

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Type check collection.py (PP-503) #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2202d4c
Type check collection.py
jonathangreen Oct 25, 2023
f6e07c2
Fix import issue
jonathangreen Oct 25, 2023
d501e5a
Remove unused ignore
jonathangreen Oct 25, 2023
84350bb
Make sure multitest has integration configuration.
jonathangreen Oct 25, 2023
28557eb
Add another test
jonathangreen Oct 25, 2023
c7a5154
Add some more tests
jonathangreen Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/model/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,16 @@ class Subject(Base):
OVERDRIVE = Classifier.OVERDRIVE # Overdrive's classification system
BISAC = Classifier.BISAC
BIC = Classifier.BIC # BIC Subject Categories
TAG = Classifier.TAG # Folksonomic tags.
FREEFORM_AUDIENCE = Classifier.FREEFORM_AUDIENCE
TAG: str = Classifier.TAG # Folksonomic tags.
FREEFORM_AUDIENCE: str = Classifier.FREEFORM_AUDIENCE
NYPL_APPEAL = Classifier.NYPL_APPEAL

# Types with terms that are suitable for search.
TYPES_FOR_SEARCH = [FAST, OVERDRIVE, BISAC, TAG]

AXIS_360_AUDIENCE = Classifier.AXIS_360_AUDIENCE
GRADE_LEVEL = Classifier.GRADE_LEVEL
AGE_RANGE = Classifier.AGE_RANGE
AGE_RANGE: str = Classifier.AGE_RANGE
LEXILE_SCORE = Classifier.LEXILE_SCORE
ATOS_SCORE = Classifier.ATOS_SCORE
INTEREST_LEVEL = Classifier.INTEREST_LEVEL
Expand Down
Loading