-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type check collection.py (PP-503) #1481
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
- Coverage 90.39% 90.37% -0.02%
==========================================
Files 231 231
Lines 29577 29596 +19
Branches 6894 6908 +14
==========================================
+ Hits 26735 26747 +12
- Misses 1814 1816 +2
- Partials 1028 1033 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
25591cf
to
c7a5154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Description
Add type checking information to
collection.py
before refactoring.Motivation and Context
First step for PP-503.
How Has This Been Tested?
Running tests locally and in CI.
Checklist