Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check collection.py (PP-503) #1481

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Conversation

jonathangreen
Copy link
Member

Description

Add type checking information to collection.py before refactoring.

Motivation and Context

First step for PP-503.

How Has This Been Tested?

Running tests locally and in CI.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cafb589) 90.39% compared to head (c7a5154) 90.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   90.39%   90.37%   -0.02%     
==========================================
  Files         231      231              
  Lines       29577    29596      +19     
  Branches     6894     6908      +14     
==========================================
+ Hits        26735    26747      +12     
- Misses       1814     1816       +2     
- Partials     1028     1033       +5     
Flag Coverage Δ
Api 73.52% <70.21%> (+0.01%) ⬆️
Core 61.03% <87.23%> (-0.01%) ⬇️
migration 28.48% <47.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/model/classification.py 79.37% <100.00%> (ø)
core/model/contributor.py 92.27% <100.00%> (ø)
core/model/hassessioncache.py 100.00% <100.00%> (ø)
core/model/integration.py 95.91% <100.00%> (+0.17%) ⬆️
core/opds_import.py 89.61% <100.00%> (ø)
core/model/library.py 96.66% <66.66%> (-0.47%) ⬇️
core/model/collection.py 94.01% <89.61%> (-1.83%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen force-pushed the feature/type-check-collection branch from 25591cf to c7a5154 Compare October 25, 2023 20:35
@jonathangreen jonathangreen requested a review from a team October 25, 2023 22:04
Copy link
Contributor

@RishiDiwanTT RishiDiwanTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jonathangreen jonathangreen merged commit f365044 into main Oct 26, 2023
30 checks passed
@jonathangreen jonathangreen deleted the feature/type-check-collection branch October 26, 2023 12:37
jonathangreen added a commit that referenced this pull request Oct 26, 2023
This is a follow up to #1481. Remove a number of functions that are not used on collections. It looks like they existed to support the metadata wrangler at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants