Give OPDS importers an API class (PP-501) #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
changed the title
jonathangreen
force-pushed
the
feature/opds-importer-api
branch
from
b3bfed8 to
139ec87
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
+ Coverage 90.38% 90.40% +0.01%
==========================================
Files 233 231 -2
Lines 29713 29718 +5
Branches 6793 6874 +81
==========================================
+ Hits 26857 26867 +10
+ Misses 1823 1822 -1
+ Partials 1033 1029 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
feature/opds-importer-api
branch
from
bd11b38 to
6513307
Compare
|
I started a review of this today and plan to finish it up tomorrow. |
tdilauro
reviewed
Oct 18, 2023
tests/api/mockapi/circulation.py
Outdated
| @@ -15,7 +21,7 @@ | |||
| from tests.mocks.search import ExternalSearchIndexFake | |||
|
|
|||
|
|
|||
| class MockBaseCirculationAPI(BaseCirculationAPI, ABC): | |||
| class MockBaseCirculationAPI(PatronActivityCirculationAPI, ABC): | |||
There was a problem hiding this comment.
Seems like this should get a different name, MockPatronActivityCirculationAPI, to avoid confusion about what is being mocked.
tests/fixtures/odl.py
Outdated
Comment on lines
36
to
37
| @staticmethod | ||
| def _queue_response(self, status_code, headers={}, content=None): |
There was a problem hiding this comment.
This is decorated as a static method, but accepts and uses self. If this is intentional, it would be helpful to use a different name for self and add a comment about what is happening.
There was a problem hiding this comment.
I added a comment to clarify.
2 tasks
jonathangreen
force-pushed
the
feature/opds-importer-api
branch
from
507c8e7 to
078ae8c
Compare
|
Rebased on main, and made code review changes. |
jonathangreen
added a commit
that referenced
this pull request
Oct 20, 2023
As a follow up to #1442, this removes the CirculationFulfillmentPostProcessor class. All the logic has been moved into the OPDSAPI and OPDS2API classes. CirculationFulfillmentPostProcessor were only used to work around OPDS importers not having an API class. Now that we have a proper API class there, there is no reason to keep them around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously OPDS importers were a special case, they had no API class, there there was a special code path for checkouts and fulfillment taken. Now they are treated like every other license source, with their own
BaseCirculationAPI.Motivation and Context
This is another step along the path to removing external integrations from license source integrations.
How Has This Been Tested?
Checklist