Remove circulation api post processor (PP-501) #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/opds-importer-api
branch
from
507c8e7 to
078ae8c
Compare
jonathangreen
force-pushed
the
feature/remove-circulation-api-post-processor
branch
from
45eb58c to
3e31953
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
- Coverage 90.40% 90.40% -0.01%
==========================================
Files 230 231 +1
Lines 29693 29771 +78
Branches 6870 6880 +10
==========================================
+ Hits 26845 26914 +69
- Misses 1818 1823 +5
- Partials 1030 1034 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
tdilauro
approved these changes
Oct 20, 2023
api/circulation.py
Outdated
Comment on lines
638
to
640
| return self.settings_class().construct( | ||
| **self.integration_configuration().settings_dict | ||
| ) |
There was a problem hiding this comment.
Might need to resolve some changes from #1472 here when you merge/rebase main.
tests/api/test_axis.py
Outdated
| pytest.raises( | ||
| ProblemError, MockAxis360API, axis360.db.session, axis360.collection | ||
| ) | ||
| pytest.raises(ProblemError, Axis360Settings, **settings) |
There was a problem hiding this comment.
#1472 changes here, as well, I think.
jonathangreen
force-pushed
the
feature/remove-circulation-api-post-processor
branch
from
21a3b3e to
034d11e
Compare
jonathangreen
deleted the
feature/remove-circulation-api-post-processor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1442, this removes the
CirculationFulfillmentPostProcessorclass. All the logic has been moved into the OPDSAPI and OPDS2API classes.Motivation and Context
CirculationFulfillmentPostProcessorwere only used to work around OPDS importers not having an API class. Now that we have a proper API class there, there is no reason to keep them around.How Has This Been Tested?
Running tests.
Checklist