add eslint and apply initial rules

.editorconfig

@@ -0,0 +1,16 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+max_line_length = 80
+
+[*.json]
+indent_style = space
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false

.eslintrc

@@ -0,0 +1,12 @@
+{
+  "parser": "babel-eslint",
+  "env": {
+    "node": true
+  },
+  "rules": {
+    "indent": ["error", 2, { "SwitchCase": 1 }],
+    "semi": ["error", "always"],
+    "comma-dangle": ["error", "always-multiline"],
+    "quotes": ["error", "single", { "allowTemplateLiterals": true }]
+  }
+}

app/car.js

@@ -13,4 +13,3 @@ export class SportsCar {
 console.log(
   new SportsCar(new V8Engine()).toString()
 );
-

app/car.spec.js

@@ -1,16 +1,15 @@
 
-import {V6Engine, V8Engine, getVersion} from './engine';
-
-import {SportsCar} from './car';
+import { V6Engine, V8Engine, getVersion } from './engine';
+import { SportsCar } from './car';
 
 describe('Car - ',() => {
-  it('should have a V8 Engine',() => {    
+  it('should have a V8 Engine',() => {
     let car = new SportsCar(new V8Engine());
-    expect(car.toString()).toBe('V8 Sports Car')    
-  })
+    expect(car.toString()).toBe('V8 Sports Car');
+  });
 
-  it('should have a V6 Engine',() => {    
+  it('should have a V6 Engine',() => {
     let car = new SportsCar(new V6Engine());
-    expect(car.toString()).toBe('V6 Sports Car')    
-  })
-})
+    expect(car.toString()).toBe('V6 Sports Car');
+  });
+});

app/engine.js

@@ -12,4 +12,4 @@ export class V8Engine {
 
 export function getVersion() {
   return '1.0';
-}
+}

app/engine.spec.js

@@ -1,19 +1,17 @@
-import {V6Engine, V8Engine, getVersion} from './engine';
+import { V6Engine, V8Engine, getVersion } from './engine';
 
 describe('Engine - ',() => {
- it('should have a v6 engine', () => {
-   let v6 = new V6Engine();
-   expect(v6.toString()).toBe('V6');
- })
+  it('should have a v6 engine', () => {
+    let v6 = new V6Engine();
+    expect(v6.toString()).toBe('V6');
+  });
 
- it('should have a v8 engine', () => {
-   let v8 = new V8Engine();
-   expect(v8.toString()).toBe('V8');
- })
+  it('should have a v8 engine', () => {
+    let v8 = new V8Engine();
+    expect(v8.toString()).toBe('V8');
+  });
 
- it('should get version', () => {   
-   expect(getVersion()).toBe('1.0');
- })
-
-
-})
+  it('should get version', () => {
+    expect(getVersion()).toBe('1.0');
+  });
+});

custom-loader.js

@@ -3,8 +3,6 @@ module.exports = loader;
 // The simplest loaders are functions which take a files source (as raw string)
 // and return the modified source. This is a great starting place to learn to use loaders.
 function loader(source) {
-	debugger; 
-
-
-	return source;
-}
+  debugger;
+  return source;
+}

e2e.spec.js

@@ -21,7 +21,7 @@ describe('Webpack Dev Kit - Dev Script', () => {
     npmTask = child.spawn('npm', ['run', 'dev']);
     let run = false; //make sure to only call done once
     npmTask.stdout.on('data', (data) => {
-      //search for 'bundle valid' string to make sure it's finished running 
+      //search for 'bundle valid' string to make sure it's finished running
       let str = data.toString();
       if (str.indexOf('webpack: bundle is now VALID.') !== -1) {
         if (!run) {
@@ -44,7 +44,7 @@ describe('Webpack Dev Kit - Dev Script', () => {
       npmTask.kill();
       done();
     });
-  })
+  });
 
   it('should have the title "Webpack Developer Kit"', (done) => {
     expect($('title').text()).toBe('Webpack Developer Kit');
@@ -55,4 +55,4 @@ describe('Webpack Dev Kit - Dev Script', () => {
     expect($('script').attr('src')).toBe('car.bundle.js');
     done();
   });
-});
+});

package.json

@@ -6,7 +6,8 @@
   "scripts": {
     "dev": "webpack-dev-server --inline --content-base build/",
     "build": "rimraf ./dist && webpack --config webpack.config.js",
-    "test:unit":"jest",
+    "lint": "eslint .",
+    "test:unit": "jest",
     "test:e2e": "jasmine e2e.spec.js",
     "debug": "node --inspect --debug-brk ./node_modules/webpack/bin/webpack.js --config webpack.config.js"
   },
@@ -26,12 +27,13 @@
     "email": "[email protected]"
   },
   "license": "MIT",
-  "jest":{
-    "rootDir":"./app/"
+  "jest": {
+    "rootDir": "./app/"
   },
   "dependencies": {},
   "devDependencies": {
     "babel-core": "^6.14.0",
+    "babel-eslint": "^7.0.0",
     "babel-loader": "^6.2.5",
     "babel-preset-es2015": "^6.14.0",
     "babel-preset-latest": "^6.14.0",
@@ -40,6 +42,7 @@
     "cheerio": "0.22.0",
     "chromedriver": "2.24.1",
     "enhanced-resolve": "^2.3.0",
+    "eslint": "^3.7.1",
     "html-webpack-plugin": "^2.22.0",
     "http-server": "^0.9.0",
     "jasmine": "2.5.2",

webpack.config.js

@@ -9,58 +9,58 @@ const path = require('path');
 
 module.exports = {
   entry: {
-    'car': ['./app/car.js']
+    'car': ['./app/car.js'],
   },
   output: {
     path: path.join(__dirname,'/dist'),
-    filename: '[name].bundle.js'
+    filename: '[name].bundle.js',
   },
   module: {
     rules: [
-      // We are chianing the custom loader to babel loader. 
+      // We are chianing the custom loader to babel loader.
       // Purely optional but know that the `first` loader in the chain (babel in this case)
       // must always return JavaScript (as it is then processed into the compilation)
       {
-        test: /\.js$/, 
+        test: /\.js$/,
         oneOf: [
-          { 
+          {
             loaders: [
-              'babel', 
-              'custom-loader'
-            ] 
-          }
-        ]
-      }
-    ]
+              'babel',
+              'custom-loader',
+            ],
+          },
+        ],
+      },
+    ],
   },
   // This allows us to add resolving functionality for our custom loader
-  // It's used just like the resolve property and we are referencing the 
+  // It's used just like the resolve property and we are referencing the
   // custom loader file.
   resolveLoader: {
     alias: {
-      "custom-loader": require.resolve('./custom-loader')
-    }
+      'custom-loader': require.resolve('./custom-loader'),
+    },
   },
   plugins: [
     // This function is the `apply` function if you were to create an external plugin
     // Having it inline provides some nice conviences for debugging and development
     function() {
       var compiler = this;
-      compiler.plugin("compilation", function(compilation) {
-        compilation.plugin("after-optimize-modules", function(modules) {
+      compiler.plugin('compilation', function(compilation) {
+        compilation.plugin('after-optimize-modules', function(modules) {
           // debugger;
         });
-        compilation.plugin("after-optimize-chunks", function(chunks) {
+        compilation.plugin('after-optimize-chunks', function(chunks) {
           // debugger;
         });
       });
     },
     new HtmlWebpackPlugin({
-      template: './app/index.html'
-    })
+      template: './app/index.html',
+    }),
   ],
   resolve: {
-    extensions: ['.js']
+    extensions: ['.js'],
   },
-  devtool: false
+  devtool: false,
 };