Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eslint and apply initial rules #21

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

vutran
Copy link
Contributor

@vutran vutran commented Oct 11, 2016

This PR adds eslint (#5) with some initial rules along with an .editorconfig file for editor consistency (#20).

I know I mentioned to utilized webpack's rules but it would require a lot of reformatting of the white-space so I figured keeping the current 2-space indents.

Initial General Ruleset:

  • 2-space indentation
  • Semicolons
  • Comma-dangle for multiple objects for better git diffs
  • Use single quotes for strings (a few were using double-quotes so applying this for consistency)

To run:

$ npm run lint

Copy link
Owner

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you so much!!

@TheLarkInn TheLarkInn merged commit c349e69 into TheLarkInn:master Oct 14, 2016
@vutran vutran deleted the add-eslint branch October 14, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants