Add PartitionDocument and ItemizedFileDocument #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Register a shutdown hook to delete the file when the JVM exits | ||
| sys.addShutdownHook { | ||
| withWriteLock { |
There was a problem hiding this comment.
why do we need a write lock, do we allow multiple writers to write the file?
| override val bufferSize: Int = 1024 | ||
|
|
||
| // Register a shutdown hook to delete the file when the JVM exits | ||
| sys.addShutdownHook { |
There was a problem hiding this comment.
The lifecycle for this file is also not correct. This file is created by the computing unit JVM, which can be killed right after the execution.
There was a problem hiding this comment.
I suggest we do a global cleanup on OpResultStorage level on top of #3146.
bobbai00
force-pushed
the
jiadong-add-file-result-storage
branch
2 times, most recently
from
6522779 to
a83d779
Compare
bobbai00
force-pushed
the
jiadong-add-file-result-storage
branch
from
a83d779 to
24ada36
Compare
bobbai00
force-pushed
the
jiadong-add-file-result-storage
branch
from
1edb551 to
cef347b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two document implementations:
PartitionDocument: given an ID, and number of partitionsn, this document will createnfiles, each file is aItemizedFileDocument.ItemizedFileDocument: given a URI, this document will open/create if not exist a file on the filesystem, and provide implementation of read/write in a sequence. It accepts the template typeT, and it will use kryo to serde/deserde the type T during read and write.