-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IcebergDocument as one implementation of VirtualDocument #3147
Open
bobbai00
wants to merge
28
commits into
master
Choose a base branch
from
jiadong-add-file-result-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1fe9f17
add itemized file document and partition document
bobbai00 219b82d
add unit test for PartitionDocument
bobbai00 e446e9c
add more to unit tests
bobbai00 9627b25
make PartitionDocument return T
bobbai00 b85fd45
fix partition document test
bobbai00 8e6fec3
refining the documents
bobbai00 288aea4
add type R to PartitionedItemizedFileDocument
bobbai00 c3a1d00
do a rename
bobbai00 97c601e
adding the arrow file document, TODO: fix the test
bobbai00 e2c5515
pass the compilation
bobbai00 c17a54e
finish arrow document
bobbai00 bc38cc4
start to add some iceberg related
bobbai00 51dd7cf
finish initial iceberg writer
bobbai00 481c437
finish initial version of iceberg
bobbai00 0274f66
refactor test parts
bobbai00 4663fef
finish 1st viable version
bobbai00 9607f98
fix the append read
bobbai00 d2d0ed7
finish append read
bobbai00 f4ea0e3
finish concurrent write test
bobbai00 e46311c
resolve the binary type issue
bobbai00 5467b6f
refactor the util and config
bobbai00 d92a5ad
add a simple implementation for getRange and getAfter
bobbai00 15508b9
try to add iceberg as new type of result storage
bobbai00 c234dfd
closing to fix the dependency
bobbai00 4213a5b
fix the websocket connection
bobbai00 11ce821
add create override
bobbai00 129453e
add more comments and adjust the dependency
bobbai00 d553e32
add worker id when creating the writer
bobbai00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,27 @@ | ||
storage: | ||
result-storage-mode: memory | ||
result-storage-mode: iceberg | ||
mongodb: | ||
url: "mongodb://localhost:27017" | ||
database: "texera_storage" | ||
commit-batch-size: 1000 | ||
iceberg: | ||
catalog: | ||
jdbc: # currently we only support storing catalog info via jdbc, i.e. https://iceberg.apache.org/docs/1.7.1/jdbc/ | ||
url: "jdbc:mysql://0.0.0.0:3306/texera_iceberg?serverTimezone=UTC" | ||
username: "root" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make sure to clean up those username and passwords. |
||
password: "123456" | ||
table: | ||
namespace: "operator-result" | ||
commit: | ||
batch-size: 4096 # decide the buffer size of our IcebergTableWriter | ||
retry: | ||
# retry configures the OCC parameter for concurrent write operations in Iceberg | ||
# Docs about Reliability in Iceberg: https://iceberg.apache.org/docs/1.7.1/reliability/ | ||
# Docs about full parameter list and their meaning: https://iceberg.apache.org/docs/1.7.1/configuration/#write-properties | ||
num-retries: 10 | ||
min-wait-ms: 100 # 0.1s | ||
max-wait-ms: 10000 # 10s | ||
jdbc: | ||
url: "jdbc:mysql://localhost:3306/texera_db?serverTimezone=UTC" | ||
username: "" | ||
password: "" | ||
url: "jdbc:mysql://0.0.0.0:3306/texera_db?serverTimezone=UTC" | ||
username: "root" | ||
password: "123456" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some comments to explain why it's blank.