Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test2::Hub - fix remove_context_{aquire,init,release} logic #999

Merged
merged 1 commit into from
Aug 13, 2024

Commits on Aug 13, 2024

  1. Test2::Hub - fix remove_context_{aquire,init,release} logic

    As far as I can tell, the intended logic is:
    
     1. Build a set from passed-in arguments, represented as a hash.
     2. Keep only context handlers that are not elements of the set (i.e.
        not keys of the hash).
    
    However, what the code actually did was to compare the result of `!`
    (which is a boolean, numerically 0 or 1) to a coderef, which is always
    false. In other words, the remove_context_* methods would ignore their
    arguments and always remove everything.
    mauke committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b570354 View commit details
    Browse the repository at this point in the history