Test2::Hub - fix remove_context_{aquire,init,release} logic #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
force-pushed
the
fix-remove-handler-logic-bug
branch
from
caf9a10
to
2ea0a29
Compare
|
Do you have an example case where this was causing a problem? If so I would be interested in making a test related to it, |
|
No, I don't even know what these methods are for. I noticed the issue because I added a new warning to blead perl. |
As far as I can tell, the intended logic is:
1. Build a set from passed-in arguments, represented as a hash.
2. Keep only context handlers that are not elements of the set (i.e.
not keys of the hash).
However, what the code actually did was to compare the result of `!`
(which is a boolean, numerically 0 or 1) to a coderef, which is always
false. In other words, the remove_context_* methods would ignore their
arguments and always remove everything.
mauke
force-pushed
the
fix-remove-handler-logic-bug
branch
from
2ea0a29
to
b570354
Compare
|
I have to look deeper into this. I suspect I meant |
|
actually, having re-read it, yeah, I think you got it correct here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the intended logic is:
However, what the code actually did was to compare the result of
!(which is a boolean, numerically 0 or 1) to a coderef, which is always false. In other words, the remove_context_* methods would ignore their arguments and always remove everything.