-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-10971-swipe-down-gesture-too-sensitive #11642
Closed
Closed
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ef1789b
Gradle issue fix
u7759982 96fc910
::bug:: fixed content is not allowed in prolog, @list_stream_card_ite…
u7759982 dcb232f
:hit: log files to help me find the place
u7759982 9333fab
:ongoing: Can no prevent very fast minimize with low distance, but an…
u7759982 ebadccb
delete customer log functions
u7759982 a8c1708
adjust the parameter to find a proper threshold
u7759982 626367b
add more detailed explanation
u7759982 471de5c
revert changes to list_stream_card_item.xml, since it is environment …
u7759982 6655854
Merge branch 'dev' into issue10971
u7759982 56c88b1
Merge pull request #1 from u7759982/issue10971
u7759982 6b42538
revert changes to gradle files sice its failed
u7759982 27c57a4
Merge pull request #2 from u7759982/issue10971
u7759982 3de7427
Merge branch 'TeamNewPipe:dev' into dev
u7759982 fb2b605
Update app/src/main/java/org/schabi/newpipe/player/gesture/CustomBott…
u7759982 582e5f8
Merge branch 'TeamNewPipe:dev' into dev
u7759982 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clean your git history (rebase) and this is fixed on the dev branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your detailed advice. I am still wondering about whether implementing swipe down threshold is a proper methods to solve this. As when the threshold is implemented. Within the threshold, the user gesture will be ignored and no interaction can be seen. Previously, the instantce user drag the screen, the view window will move with the drag. After distance threshold implementation, within the threshold distance, when you drag, there is no response, the window will not move. I am not very sure if this is the correct direction to solve this problem.