issue-10971-swipe-down-gesture-too-sensitive

[u7759982]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

1. change alphbet case from gradle file dependencies libraries, otherwise, gradle will fail
   Before :
   
   After:
   
2. Implement distance threshold for the CustomBottomSheetBehavior
   Files that changed: app/src/main/java/org/schabi/newpipe/player/gesture/CustomBottomSheetBehavior.java
   Change screenshoots:
   
   the distance threshold can be changed.
   

Before/After Screenshots/Screen Record

• Before: Swipe down gesture with very little distance but high speed will make the bottom sheet collapse

before.mp4

• After: Implement a distance threshold to avoid too sensitive，also avoid accident swipe

after.mp4

Fixes the following issue(s)

• Fixes player swipe down gesture too sensitive #10971

APK testing

Due diligence

• I read the contribution guidelines.

[TobiGr]

Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university.

[u7759982]

Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university.

Thanks for your reply, and yes, I am an ANU student at present. I think the CI fails possibly due to the reason I changed the character case, and I revert these changes.

[TobiGr]

Thank you for the PR. Please rebase it and follow the linter / checkstyle. I'll take a closer look once the pipelines succeed.

One general tip when working with platforms like GitHub and GitLab to propose changes and / or get code reviews: You do not need to post screenshots of your changes. The changes are tracked. If you want to comment on your changes, you can either reference them in the PR body or start discussions directly as part of the code review.

[TobiGr]

please clean your git history (rebase) and this is fixed on the dev branch.

[u7759982]

Thanks for your detailed advice. I am still wondering about whether implementing swipe down threshold is a proper methods to solve this. As when the threshold is implemented. Within the threshold, the user gesture will be ignored and no interaction can be seen. Previously, the instantce user drag the screen, the view window will move with the drag. After distance threshold implementation, within the threshold distance, when you drag, there is no response, the window will not move. I am not very sure if this is the correct direction to solve this problem.

[Stypox]

Hello, and thank you for your contribution. I agree that just ignoring the gesture is not good UX. However in the refactored NewPipe gestures will be handled by NewPlayer, so any improvements should go there. Thank you anyway for your PR, I'm sorry for not giving you the chance to improve it right now, but we want to focus all of our energies on the refactor.