-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pnpm) - migrate from YarnV1 to PNPM #5254
Draft
smouillour
wants to merge
157
commits into
master
Choose a base branch
from
smouillour/fix/pnpm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
157 commits
Select commit
Hold shift + click to select a range
9e1dac4
big commit pnpm
03d2f1a
syn with master
de2c965
add warn pnpm
160eaf7
fix
5654709
fix: build icons
jmfrancois 3bd4e96
chore: remove enzyme and fix some lint
jmfrancois c72ba53
fix: prettier
jmfrancois 9528a05
chore: lint forms
jmfrancois d104543
chore: CI on pnpm
jmfrancois 2b87eee
chore: CI use pnpm everywhere
jmfrancois d4250ea
chore: remove cache-loader deprecated webpack plugin
jmfrancois 930d566
npmrc + remove @talend/scripts-config-babel
32e236c
chore: add typescript config devDep for VSCode
jmfrancois 7ed6a6a
Merge branch 'smouillour/fix/TDOPS-5327-pnpm' of github.com:Talend/ui…
jmfrancois fd29e1c
revert
c1b527b
add "@talend/scripts-config-typescript": "^11.1.0" in package having …
3313a64
add @talend/scripts-config-babel in each package with babel file
19c72e7
fix import testing-library
bb9e680
a11n add compiler option with type jest
e5d894a
add compiler option in http to add type jest
092b39d
fix package util adding type lodash
8cf2480
try to fix issue with jsfc (missing babel-loader)
fd58ec4
revert change made on jsfc
6749610
remove babel-loader to config-react-webpack and add it (+add webapp) …
7459b77
Merge 67496107ffbb4cabcc41b97ac4e16ee7968c12e9 into cd04f75e88298e9b8…
smouillour 527af9c
chore: pnpm-deduplicate
github-actions[bot] 9001885
remove yarn in tool-versions
4e7be57
change way to call webpack in build-lib-umd
8b6656e
try something to inprove findPackagesFromScopeFolder for PNPM
c2acf07
DRAFT PNPM 2(#4932)
smouillour 9bc0d00
fix lockfile
f305cfb
More fixes (#4934)
smouillour 813cdca
DRAFT PNPM 5 (more fixes) (#4938)
smouillour 89ed2f3
Merge 813cdcacde6cbf5907dbab2275cf31436f0121e1 into 6efd54301e87eff51…
smouillour 46de8a2
chore: pnpm-deduplicate
github-actions[bot] 1c97306
Merge with master and manage conflict
27f728b
fixes after merge
fc54ed1
Sync with master
385f14d
update pnpm lock
74eae57
Merge 385f14dabe1b3b9f2fbc6b05e81747ee2516c33f into 35263dfcb1c1b3028…
smouillour 2e97a30
chore: pnpm-deduplicate
github-actions[bot] 1906997
fix prettier
14add4a
add missing deps in scripts-config-storybook-lib
8c6fd49
Sync with master
4b5cbb3
fix tests impacted by fix with prettier
65d448a
add eslint to module-to-cdn
07a20eb
fix(TDOPS-5502): PNPM - Prepare scripts-config-babel and packages dep…
93c3b79
add missing one + add babel.config.js in npmignore files
a11b253
fix missing changes
be1e8a6
Merge a11b2534df44de9ff14cdc23484bbad7bd846c67 into 96d688489246d683e…
smouillour 652ec0d
chore: yarn-deduplicate
github-actions[bot] c39e54b
add changeset and revert useless changes in npmignore
75ca249
Merge branch 'master' into smouillour/fix/TDOPS-5502
smouillour 123c4b8
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5502
0ca28ed
fix: remove dep between eslint config and script utils
jmfrancois 0fc2b84
chore: remove babel config form module-to-cdn as it is not used
jmfrancois eff5912
chore: kill the breaking change
jmfrancois 1b7d997
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5502
d4d0183
sync with smouillour/fix/TDOPS-5502
1cb523b
sync with Master
6829525
Merge 1cb523b6e221c6a5556e56755a186e1e1de40c50 into 3f9c8a7bbddfafc93…
smouillour ae730ff
chore: pnpm-deduplicate
github-actions[bot] c32eceb
remove tsconfig.build to remind why i added them + fix scripts-utils …
aaf287b
Merge c32eceb11e1abb9a77b0179afc2df699dc37115e into 3f9c8a7bbddfafc93…
smouillour f710b4d
chore: pnpm-deduplicate
github-actions[bot] c09eb2e
remove babelrc in scripts-utils
551ddd2
fix issues
460b50d
some fix
a2f8c0c
fix storybook
6ff881d
Add pnpm setup
99364a8
fix pnpm store
8f95e3a
try another fix with pnpm setup
08c00d2
one more try to fix pnpm setup
984a37e
one more try
8ec1f82
try to fix pnpm global bin dir
7b6e15d
go back to pnpm/action-setup
a8d1072
fix
e9bfb11
fix missing deps
9f83275
add missing deps
3b7b45d
fix for playground
400f5d9
fix playground deps
3c91352
Merge with Master
851c6f4
fix talend versions
80fd394
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5327-…
935404b
npmrc: add cypress in public-hoist-pattern
ec6a726
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5327-…
77bc7e4
fix tests in dynamic-cdn-webpack-plugin
1a21d99
add condition to manage issue using pnpm/action-setup
30bdeb9
fix edge case due to pnpm/action-setup
abdedd3
fix eslint in multiple packages
5eeb0ee
fix forms test
1aac508
Merge 5eeb0eeb2b74226244d2e5797b0474b284c12243 into a0fdcfa961aa137be…
smouillour 15dccc4
chore: pnpm-deduplicate
github-actions[bot] 07038c3
upgrade version of pnpm needed
3ad6e1d
fix scripts-core usage as devDep instead of dep
8d5d34c
revert one change in dynamic-cdn-webpack-plugin (find)
f250513
fix lint
6a06216
fix usage of loader 'source-map-loader' in scripts-config-react-webpack
8a97f20
Merge with Master
f47cd02
Fix version after merge with master
15bbb2c
fix lock file
40d3567
Merge with Master
6886e12
Merge 40d35678b526965cd65d8fc918b9bc2dbd52070d into e82cc7f30406efff3…
smouillour 1e859e9
chore: pnpm-deduplicate
github-actions[bot] 2547a2f
Sync with master managing conflict
fbea33c
remove changeset not needed
2335784
revert remove of .babelrc.json to keep compatibility
6d52560
undo changes made in this file
3d72111
Fix detected issue with yarn
ff7bc49
Fix after review in another PR
872d4bc
Sync with Master
163f9ba
update pnpm-lock
060ec78
revert change
672ae7d
fix playground
ce17d45
fix
6863eed
fix scripts-config-react-webpack for playground basename
30c0009
fix
d011e33
Sync with master
aebb874
fix
8f3c55d
Sync with master
26f7304
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5327-…
70dba13
fix cypress
3a4e2f1
fix cypress
58469a7
fix for test cypress
25596bf
move lint merge-report to scripts-core
c5531b3
fix gha dependencies + more
e14ea2a
Merge with master
1cb1632
Merge e14ea2af2d27c3c85594286d7f1a0f1dc498c492 into 5455b651717d5d1b5…
smouillour 80c23e2
chore: pnpm-deduplicate
github-actions[bot] 7e8cf5d
fix
4719211
fix
b7ccea6
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5327-…
2ec1cc3
merge with master
e41a9cf
revert some changes
1cea9f7
Merge e41a9cf4e2dba790745ddbba218d57b3eccedae3 into faa8bb3f8c2706807…
smouillour 341e158
chore: pnpm-deduplicate
github-actions[bot] 71d3ede
fix lint
e1ecf22
fix
172252a
sync with master
a724744
sync with master
c7fe896
Merge a724744e1ed4e713de1ccceb09694382a503d409 into b5fc2c3bb53d5006c…
smouillour f03f18d
chore: pnpm-deduplicate
github-actions[bot] 397a559
update pnpm version
c8407b1
sync with master
4785a34
upgrade deps
7359601
Merge 4785a346f0dbe30271b78ff663d9d0dd71e638bd into 92ff355c7bcb7ffd4…
smouillour 85169dc
chore: pnpm-deduplicate
github-actions[bot] 7834cc6
Merge remote-tracking branch 'origin' into smouillour/fix/TDOPS-5327-…
e62267d
Merge 7834cc60903188c17ef865958477482e7abf5f89 into 38dad22dc6467891b…
smouillour 135b47a
chore: pnpm-deduplicate
github-actions[bot] be8de20
sync with master
smouillour d821af8
Merge be8de205585ddaeb6250b6a8256fc2598f58f59d into e12b3cd3d1a5e9806…
smouillour be131a7
chore: pnpm-deduplicate
github-actions[bot] b4b9378
fix bug
smouillour 9c7cdbe
Merge b4b937823411de0b519e6d6ff65942bebb64aa4a into e12b3cd3d1a5e9806…
smouillour d0fd9d1
chore: pnpm-deduplicate
github-actions[bot] a33a4cc
upgrade pnpm version in .tool-versions
smouillour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,19 +14,31 @@ runs: | |
registry-url: 'https://registry.npmjs.org/' | ||
scope: '@talend' | ||
|
||
- name: Install yarn | ||
shell: bash | ||
run: npm i -g yarn | ||
# - name: Install PNPM | ||
# shell: bash | ||
# run: npm install -g [email protected] | ||
|
||
# - name: Setup PNPM | ||
# shell: bash | ||
# run: | | ||
# mkdir ~/.local/share/pnpm | ||
# pnpm config set global-bin-dir ~/.local/share/pnpm | ||
|
||
- uses: pnpm/action-setup@v2 | ||
name: Install pnpm | ||
with: | ||
version: 8 | ||
run_install: false | ||
|
||
- name: Get yarn cache directory path | ||
id: yarn-cache-dir-path | ||
- name: Get pnpm cache directory path | ||
id: pnpm-cache-dir-path | ||
shell: bash | ||
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT | ||
run: echo "dir=$(pnpm store path)" >> $GITHUB_OUTPUT | ||
|
||
- uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #v3.3.2 | ||
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | ||
id: pnpm-cache # use this to check for `cache-hit` (`steps.pnpm-cache.outputs.cache-hit != 'true'`) | ||
with: | ||
path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
path: ${{ steps.pnpm-cache-dir-path.outputs.dir }} | ||
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-yarn- | ||
${{ runner.os }}-pnpm- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# How to run github action locally | ||
|
||
Use the cli ACT: https://github.com/nektos/act | ||
|
||
# How to run PR-TEST | ||
|
||
```bash | ||
act pull_request -j build -W .github/workflows/pr-test.yml | ||
``` | ||
|
||
```bash | ||
act --container-architecture linux/amd64 pull_request -j build -W .github/workflows/pr-test.yml | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
prefer-workspace-packages=true | ||
|
||
#https://pnpm.io/blog/2020/10/17/node-modules-configuration-options-with-pnpm#plugnplay-the-strictest-configuration | ||
hoist=false | ||
|
||
######################################### | ||
# WARNGING Add public-hoist-pattern ONLY if you don't have other solution | ||
######################################### | ||
# ES LINT | ||
public-hoist-pattern[]=eslint-config-airbnb-base | ||
public-hoist-pattern[]=eslint-plugin-angular | ||
public-hoist-pattern[]=eslint-plugin-cypress | ||
public-hoist-pattern[]=eslint-plugin-import | ||
public-hoist-pattern[]=eslint-plugin-jest-dom | ||
public-hoist-pattern[]=eslint-plugin-jsx-a11y | ||
public-hoist-pattern[]=eslint-plugin-mdx | ||
public-hoist-pattern[]=eslint-plugin-prettier | ||
public-hoist-pattern[]=eslint-plugin-react | ||
public-hoist-pattern[]=eslint-plugin-react-hooks | ||
public-hoist-pattern[]=eslint-plugin-storybook | ||
public-hoist-pattern[]=eslint-plugin-testing-library | ||
|
||
# STYLE LINT | ||
public-hoist-pattern[]=postcss-scss | ||
public-hoist-pattern[]=stylelint-config-sass-guidelines | ||
|
||
# CYPRESS | ||
public-hoist-pattern[]=cypress | ||
|
||
# JEST | ||
public-hoist-pattern[]=jest-environment-jsdom | ||
public-hoist-pattern[]=jest-environment-jsdom-global | ||
public-hoist-pattern[]=jest-serializer-html | ||
|
||
# I18N | ||
public-hoist-pattern[]=i18next | ||
public-hoist-pattern[]=react-i18next | ||
public-hoist-pattern[]=i18next-http-backend | ||
|
||
# STORYBOOK | ||
public-hoist-pattern[]=@storybook* | ||
public-hoist-pattern[]=msw-storybook-addon | ||
|
||
# OTHERS | ||
public-hoist-pattern[]=autoprefixer | ||
public-hoist-pattern[]=lodash | ||
public-hoist-pattern[]=reakit | ||
public-hoist-pattern[]=react-dom | ||
public-hoist-pattern[]=redux* | ||
public-hoist-pattern[]=*types* | ||
|
||
# WEBPACK (initially needed to be able to start the playground) | ||
public-hoist-pattern[]=webpack-dev-server | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
nodejs 20.9.0 | ||
# asdf plugin-add pnpm | ||
pnpm 8.15.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.