Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pnpm) - migrate from YarnV1 to PNPM #5254

Draft
wants to merge 157 commits into
base: master
Choose a base branch
from
Draft

feat(pnpm) - migrate from YarnV1 to PNPM #5254

wants to merge 157 commits into from

Conversation

smouillour
Copy link
Contributor

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

smouillour and others added 30 commits October 12, 2023 11:25
big commit pnpm
9e1dac4
syn with master
03d2f1a
add warn pnpm
de2c965
fix
160eaf7
@jmfrancois
fix: build icons
5654709
@jmfrancois
chore: remove enzyme and fix some lint
3bd4e96
@jmfrancois
fix: prettier
c72ba53
@jmfrancois
chore: lint forms
9528a05
@jmfrancois
chore: CI on pnpm
d104543
@jmfrancois
chore: CI use pnpm everywhere
2b87eee
@jmfrancois
chore: remove cache-loader deprecated webpack plugin
d4250ea
npmrc + remove @talend/scripts-config-babel
930d566
@jmfrancois
chore: add typescript config devDep for VSCode
32e236c
@jmfrancois
Merge branch 'smouillour/fix/TDOPS-5327-pnpm' of github.com:Talend/ui…
7ed6a6a 
… into smouillour/fix/TDOPS-5327-pnpm
revert
fd29e1c
add "@talend/scripts-config-typescript": "^11.1.0" in package having …
c1b527b 
…a tsconfig file
add @talend/scripts-config-babel in each package with babel file
3313a64
fix import testing-library
19c72e7
a11n add compiler option with type jest
bb9e680
add compiler option in http to add type jest
e5d894a
fix package util adding type lodash
092b39d
try to fix issue with jsfc (missing babel-loader)
8cf2480
revert change made on jsfc
fd58ec4
remove babel-loader to config-react-webpack and add it (+add webapp) …
6749610 
…to scripts-core
@smouillour
Merge 6749610 into cd04f75
7459b77
@github-actions
chore: pnpm-deduplicate
527af9c
remove yarn in tool-versions
9001885
change way to call webpack in build-lib-umd
4e7be57
try something to inprove findPackagesFromScopeFolder for PNPM
8b6656e
@smouillour @github-actions
DRAFT PNPM 2(#4932)
c2acf07 
* remove console.log

* fix ci test

* fix cache ci test

* fix gha + jest config

* fix node_modules path, upgrade babel/core, keep jest only in scripts-core

* chore: pnpm-deduplicate

* add @talend/scripts-config-storybook-lib in every package having storybook

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:36 — with GitHub Actions Inactive
@smouillour smouillour had a problem deploying to pull_request_unsafe April 3, 2024 16:36 — with GitHub Actions Failure
@smouillour smouillour had a problem deploying to pull_request_unsafe April 3, 2024 16:36 — with GitHub Actions Failure
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:36 — with GitHub Actions Inactive
@smouillour smouillour had a problem deploying to pull_request_unsafe April 3, 2024 16:36 — with GitHub Actions Failure
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:53 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:53 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:53 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 3, 2024 16:53 — with GitHub Actions Inactive
@smouillour smouillour had a problem deploying to pull_request_unsafe April 3, 2024 16:53 — with GitHub Actions Failure
@smouillour smouillour changed the title feat(pnpm) - tmp feat(pnpm) - migrate from YarnV1 to PNPM Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.2% (1272/1426) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.78% (5599/6167) 81.89% (3247/3965) 88.29% (1411/1598)
containers Coverage: 84%
 83.71% (1388/1658) 74.81% (692/925) 75.17% (327/435)
dataviz Coverage: 85%
 85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 66%
 65.66% (914/1392) 47.93% (465/970) 52.41% (195/372)
faceted-search Coverage: 85%
 85.69% (677/790) 79.31% (303/382) 82.63% (238/288)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.39% (1625/1903) 75.53% (920/1218) 84.22% (459/545)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (73/73) 90.9% (10/11) 100% (24/24)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

5254

:octocat: Demo is available here

@smouillour smouillour temporarily deployed to pull_request_unsafe April 4, 2024 08:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 4, 2024 08:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 4, 2024 08:17 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 4, 2024 08:17 — with GitHub Actions Inactive
@smouillour smouillour had a problem deploying to pull_request_unsafe April 4, 2024 08:17 — with GitHub Actions Failure
jmfrancois
jmfrancois reviewed Apr 4, 2024
View reviewed changes
.github/workflows/dependencies.yml
Comment on lines +30 to +32
pnpm talend-upgrade-deps --ignore-scripts
pnpm talend-upgrade-deps --scope=@talend --latest --ignore-scripts
pnpm talend-upgrade-deps --latest --dry > dependencies-latest.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pnpm talend-upgrade-deps --ignore-scripts
pnpm talend-upgrade-deps --scope=@talend --latest --ignore-scripts
pnpm talend-upgrade-deps --latest --dry > dependencies-latest.txt
npx talend-upgrade-deps --ignore-scripts
npx talend-upgrade-deps --scope=@talend --latest --ignore-scripts
npx talend-upgrade-deps --latest --dry > dependencies-latest.txt

@jmfrancois
Copy link
Collaborator

This PR can't be merge has it break all UMD.
We have discussed with @smouillour and we have found the best will be to find a new way to build UMD without dynamic cdn webpack plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmfrancois jmfrancois jmfrancois left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smouillour @jmfrancois