-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Forms) : rendering lib based on json-schema-form-core #415
Changes from 52 commits
9013edc
6f0f362
cf7ba60
5356a01
dac6b4e
dd4b1ba
7e39984
f7fc2d0
400040f
2512674
0dda421
1ded597
51f54ea
1830168
7ec9032
0463505
2766c30
bc9b56a
d547e87
cc546ac
ab5ff8a
9f3f7f0
d226a6c
fd81b52
d86502f
324c312
db352cf
ffea877
8a5e149
8166191
47d9452
0a47b84
1e52f35
5405b1f
8c7f241
a5f6f14
beb4b14
91bfac1
b31228d
ae655d2
918bc05
d52186d
bed7260
f6204ac
c0030ba
64c6b9a
e341f87
82b44b8
74dd53a
343c097
bb6ff02
84c9436
75459f7
12bdd2c
2ef3c5e
c9b456a
38f131f
15033d4
75a94aa
985c923
4d59b5b
cb62f45
5d38875
ee44a89
25826cf
0c41a45
ddde2b6
1e3e2f5
0c4e75a
3a93ed7
ca567ac
14f5e5a
f1aa008
ee48ec7
9914da8
bbb51a6
86eb719
733f375
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Lerna v2.0.0-beta.36 | ||
Scoping to packages that match 'react-talend-components' | ||
|
||
> react-talend-components@0.74.2 lint:style /home/travis/build/Talend/ui/packages/components | ||
> react-talend-components@0.75.0 lint:style /home/travis/build/Talend/ui/packages/components | ||
> sass-lint -v -q | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Lerna v2.0.0-beta.36 | ||
Scoping to packages that match 'react-talend-forms' | ||
|
||
> react-talend-forms@0.74.2 lint:style /home/travis/build/Talend/ui/packages/forms | ||
> react-talend-forms@0.75.0 lint:style /home/travis/build/Talend/ui/packages/forms | ||
> sass-lint -v -q | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import React, { PropTypes } from 'react'; | ||
|
||
export default function Message(props) { | ||
const { | ||
errorMessage, | ||
description, | ||
isValid, | ||
} = props; | ||
|
||
const message = isValid ? description : errorMessage; | ||
return message ? | ||
( | ||
<div | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
className="help-block" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could use some Boostrap helper classes There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In fact I'm using Bootstrap Form Control Validation classes |
||
role="status" | ||
> | ||
{ message } | ||
</div> | ||
) : | ||
null; | ||
} | ||
|
||
if (process.env.NODE_ENV !== 'production') { | ||
Message.propTypes = { | ||
errorMessage: PropTypes.string, | ||
description: PropTypes.string, | ||
isValid: PropTypes.bool, | ||
}; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import Message from './Message.component'; | ||
|
||
export default Message; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some lints