-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Forms) : rendering lib based on json-schema-form-core #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting for json-schema-form/json-schema-form-core#4 to continue |
jsomsanith-tlnd
force-pushed
the
jmfrancois/forms-uischema-refactor
branch
from
May 9, 2017 10:20
30a7d5e
to
9013edc
Compare
frassinier
changed the title
WIP: schemform.io with react
WIP: schemzform.io with react
May 10, 2017
frassinier
changed the title
WIP: schemzform.io with react
WIP: schemaform.io with react
May 10, 2017
jsomsanith-tlnd
force-pushed
the
jmfrancois/forms-uischema-refactor
branch
from
May 11, 2017 13:13
5794d53
to
f7fc2d0
Compare
jsomsanith-tlnd
force-pushed
the
jmfrancois/forms-uischema-refactor
branch
from
May 15, 2017 13:08
1aac98a
to
51f54ea
Compare
jsomsanith-tlnd
force-pushed
the
jmfrancois/forms-uischema-refactor
branch
from
May 16, 2017 12:40
309dc26
to
0463505
Compare
talend-sromain
approved these changes
Jun 7, 2017
frassinier
approved these changes
Jun 7, 2017
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
The actual form implementation is based on mozilla's react-jsonschema-form lib which is too restrictive and miss a lot of features.
The biggest point is that it ties jsonSchema (which should represent the model), with the uiSchema format (which should represent the form, what widget, where it should appear).
For example, if we want a tab widget to manage a fieldset by tab, the jsonSchema (so the model) will be something like that :
If we want flat data but displayed with tabs, that is not possible. This introduce issues with daikkon forms.
What is the chosen solution to this problem?
Reimplement a lib based json-schema-form-core for jsonSchema/uiSchema parsing.
You can start by reading the README
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change