Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Forms) : rendering lib based on json-schema-form-core #415

Merged
merged 78 commits into from
Jun 7, 2017

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Apr 27, 2017

What is the problem this PR is trying to solve?
The actual form implementation is based on mozilla's react-jsonschema-form lib which is too restrictive and miss a lot of features.

The biggest point is that it ties jsonSchema (which should represent the model), with the uiSchema format (which should represent the form, what widget, where it should appear).

For example, if we want a tab widget to manage a fieldset by tab, the jsonSchema (so the model) will be something like that :

{
    tab1: {
        lastname: '',
        firstname: '',
    },
    tab2: {
        address: '',
        city: '',
    }
}

If we want flat data but displayed with tabs, that is not possible. This introduce issues with daikkon forms.

What is the chosen solution to this problem?

Reimplement a lib based json-schema-form-core for jsonSchema/uiSchema parsing.

You can start by reading the README

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois
Copy link
Collaborator Author

waiting for json-schema-form/json-schema-form-core#4 to continue

@jsomsanith-tlnd jsomsanith-tlnd force-pushed the jmfrancois/forms-uischema-refactor branch from 30a7d5e to 9013edc Compare May 9, 2017 10:20
@frassinier frassinier changed the title WIP: schemform.io with react WIP: schemzform.io with react May 10, 2017
@frassinier frassinier changed the title WIP: schemzform.io with react WIP: schemaform.io with react May 10, 2017
@jsomsanith-tlnd jsomsanith-tlnd force-pushed the jmfrancois/forms-uischema-refactor branch from 5794d53 to f7fc2d0 Compare May 11, 2017 13:13
@jsomsanith-tlnd jsomsanith-tlnd force-pushed the jmfrancois/forms-uischema-refactor branch from 1aac98a to 51f54ea Compare May 15, 2017 13:08
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jsomsanith-tlnd jsomsanith-tlnd force-pushed the jmfrancois/forms-uischema-refactor branch from 309dc26 to 0463505 Compare May 16, 2017 12:40
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jsomsanith-tlnd jsomsanith-tlnd merged commit e53b9a1 into master Jun 7, 2017
@jsomsanith-tlnd jsomsanith-tlnd deleted the jmfrancois/forms-uischema-refactor branch July 26, 2017 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants