Fetaure/installed app api #941
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All TOM Toolkit INSTALLED_APPs should inherit from this class rather than the standard django.apps.AppConfig class that the startapp management command uses by default. TOMToolkitAppConfig defines (will define) the instrospectable API of a TOM Toolkit app and the methods tom_base will call for app-specific customizations.
This allows a TOMToolkit app's app config (i.e. TomTargetsConfig) to extend (or not) the TOMToolkitAppConfig methods that tom_base will call to introspect each TOMToolkit INSTALLED_APP.
4 tasks
4 tasks
These would be implemented in each INSTALLED_APP's subclass of TOMToolkitAppConfig with the app-specific nav-bar content. I'm not sure where these methods will be called from.
|
@phycodurus I think we have taken this a different direction. Would you be OK Closing this PR or having a conversation about moving forward? I feel like we could handle this better with a template and a list of available connection points. I'm not sure we actually gain much by using a base class. |
jchate6
reviewed
Sep 30, 2024
There was a problem hiding this comment.
We shouldn't need to include these specifically. They should run automatically when the app is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: this refactor creates the infrastructure for generalized integration points for tom_base to introspect a TOMToolkit INSTALLED_APP. It's worth looking at these commits in isolation because they just set things up without adding any additional, complicating functionality. (That comes next).