Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration points to templates so additional modules can be added without overriding templates #745

Open
2 of 4 tasks
jchate6 opened this issue Nov 16, 2023 · 2 comments · Fixed by #747 · May be fixed by #941
Open
2 of 4 tasks

Add integration points to templates so additional modules can be added without overriding templates #745

jchate6 opened this issue Nov 16, 2023 · 2 comments · Fixed by #747 · May be fixed by #941
Labels
Epic Overview topic for high level discussion toolkit customization Would enhance the user customization experience

Comments

@jchate6
Copy link
Contributor

jchate6 commented Nov 16, 2023

The Basic Idea here is to implement "Integration points" that would behave in a similar way to the observation facilities, with additional modules automatically being linked into reasonable locations without a TOM admin having to override a template.
Essentially this would allow a user to install a new TOM module and have links and buttons for the module automatically appear in the proper places.

This would reduce user maintenance and allow users to more easily benefit from future improvements to the TOM toolkit.

Obvious Integration points:

  • Target Detail Buttons
  • Target Detail Tabs
  • Nav Bar
  • Target List Filters

With respect to Target Detail Tabs:

  • this should include general infrastructure for this beyond the fixes in PR update redirects to target_detail page #819.
  • For example, the tab names probably shouldn't be literals in the code.
  • we might also consider that, as Tabs proliferate, the TargetDetail page might need a bit of a redesign
@github-project-automation github-project-automation bot moved this to Triage in TOM Toolkit Nov 16, 2023
@jchate6 jchate6 added the toolkit customization Would enhance the user customization experience label Nov 16, 2023
@jchate6 jchate6 linked a pull request Nov 17, 2023 that will close this issue
@jchate6 jchate6 added the Epic Overview topic for high level discussion label Nov 17, 2023
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Nov 17, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Merged (to dev) in TOM Toolkit Nov 28, 2023
@jchate6 jchate6 reopened this Nov 28, 2023
@github-project-automation github-project-automation bot moved this from Merged (to dev) to Triage in TOM Toolkit Nov 28, 2023
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Dec 1, 2023
@jchate6 jchate6 moved this from Backlog to Triage in TOM Toolkit Jan 18, 2024
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Jan 23, 2024
@phycodurus phycodurus linked a pull request May 22, 2024 that will close this issue
@phycodurus
Copy link
Contributor

phycodurus commented May 22, 2024

For a general overview of the strategy, please see PR #941, especially commits:

  1. f1974f3
  2. 00d0cb2
  3. e1d7fc9
    These commits show the basic idea which is to define a TOMToolkitAppConfig that TOMToolkit INSTALLED_APPs can inherit from (it's a subclass of django.app.AppConfig). tom_base and go
    to the Django App registry and introspect the apps there looking for the extensions that
    TOMToolkitAppConfig (and it's INSTALLED_APPs subclasses) define.

@jchate6 jchate6 moved this from Backlog to In progress in TOM Toolkit Jun 12, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Jul 12, 2024

TOMToolkit/tom_demoapp#1 Should include information about these integration points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Overview topic for high level discussion toolkit customization Would enhance the user customization experience
Projects
Status: Backlog
2 participants