Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove grating for FLOYDS observations. #693

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

jchate6
Copy link
Contributor

@jchate6 jchate6 commented Sep 28, 2023

This PR removes the grating field for FLOYDS observations.
I also added a "None" Option, though this doesn't really matter since the grating is ignored for both FLOYDS and NRES, but I could see it being confusing for observers who don't know what to do for instruments like NRES/FLOYDS that cannot take a grating.

@jchate6 jchate6 added the bug Something isn't working label Sep 28, 2023
@jchate6 jchate6 requested a review from jnation3406 September 28, 2023 11:02
@jchate6 jchate6 self-assigned this Sep 28, 2023
@jchate6 jchate6 linked an issue Sep 28, 2023 that may be closed by this pull request
@jchate6 jchate6 closed this Sep 28, 2023
@jchate6 jchate6 reopened this Sep 28, 2023
@jchate6 jchate6 requested a review from phycodurus October 4, 2023 20:24
@jchate6 jchate6 merged commit 4f0729b into dev Oct 4, 2023
21 checks passed
@jchate6 jchate6 deleted the fix/add_None_grating_for_Floyds branch October 4, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOM UI for submission of FLOYDS spectrum requires non-existant grating
2 participants