Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOM UI for submission of FLOYDS spectrum requires non-existant grating #685

Closed
rachel3834 opened this issue Sep 13, 2023 · 0 comments · Fixed by #693
Closed

TOM UI for submission of FLOYDS spectrum requires non-existant grating #685

rachel3834 opened this issue Sep 13, 2023 · 0 comments · Fixed by #693
Assignees
Labels
bug Something isn't working

Comments

@rachel3834
Copy link
Contributor

Describe the bug
When I use the TOM's default UI to request a spectrum, under 'instrument configurations' it pre-populates a menu of grating options. However, this menu does not include a 'None' option, and the FLOYDS instrument doesn't have any gratings.
As a result, when I try to valid the observation requests, I produce a sequence of errors for each configuration saying "non_field_errors: optical_element of type grating is not available on 2M0-FLOYDS-SCICAM instruments"

To Reproduce
Selecting an example target in my TOM, I navigate to the 'Observe' tab on the target page, and chose the 'Spectra' tab, completing the form given with a standard sequence of lamp flat + arc + science spectrum + arc + lamp flat, set up as a sequence of configurations. I don't think the specific parameters of the observations are relevant to this bug.

Expected behavior
The pulldown menu with the grating list should include a 'None' option, or be grayed out if the user selects an instrument which has no gratings. Advice to the user could also be added underneath this menu button as to its relevance for the selected instrument.

Desktop (please complete the following information):

  • OS: Mac OS Ventura 13.5.2
  • Browser Chrome
@rachel3834 rachel3834 added the bug Something isn't working label Sep 13, 2023
@github-project-automation github-project-automation bot moved this to Backlog in TOM Toolkit Sep 13, 2023
@jchate6 jchate6 self-assigned this Sep 13, 2023
@jchate6 jchate6 linked a pull request Sep 28, 2023 that will close this issue
@jchate6 jchate6 moved this from Backlog to In progress in TOM Toolkit Oct 3, 2023
@github-project-automation github-project-automation bot moved this from In progress to Merged (to dev) in TOM Toolkit Oct 4, 2023
@jchate6 jchate6 moved this from Merged (to dev) to Released in TOM Toolkit Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants