Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues with ads #33

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Fix various issues with ads #33

merged 4 commits into from
Aug 28, 2024

Conversation

MattiasBuelens
Copy link
Collaborator

  • The UI was correctly hidden while playing an ad, but it was still intercepting touches which prevented the clickthrough from working. Instead, we now completely remove the UI while in an ad.
  • The UI was not re-appearing correctly after finishing an ad. This happened because we were listening for adend, and player.ads.isPlaying was still true when that event fires. Fix it by listening to adbreakend instead.

Supersedes #31. (Thanks @m-derakhshan for reporting and proposing the initial fix!)

@MattiasBuelens MattiasBuelens added the bug Something isn't working label Aug 28, 2024
@MattiasBuelens MattiasBuelens mentioned this pull request Aug 28, 2024
Closed
@MattiasBuelens MattiasBuelens merged commit 8759705 into develop Aug 28, 2024
1 check passed
@MattiasBuelens MattiasBuelens deleted the fix-ads branch August 28, 2024 09:06
@m-derakhshan
Copy link
Contributor

@MattiasBuelens Thank you. Can we use it now, or do we need to wait for a new version of the library?

@MattiasBuelens
Copy link
Collaborator Author

@m-derakhshan It's out now in v1.7.2. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattiasBuelens @m-derakhshan