Changed the controller visibility during Ads #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable the system gesture near to seek bar.
disable the system gesture near to seek bar.
change the visibility of video controller when Ads are playing.
|
Good evening. |
|
Before version is like this ( after upgrading the core lib to 7.10.0) Screen.Recording.2024-08-23.at.09.30.02.mov |
fix the problem of full screen handler with edge to edge
|
Looks like something went wrong with this PR. I've reopened it as #33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
We already opened a ticket for this issue a couple of months ago. We changed the library internally for our use, but now I noticed you've updated it. However, it still has some issues.
Even though you don't show the controllers during Ads, users still can't click on Ads buttons like
more infoor "skip`.I upgraded the core version since the Ads callbacks seem incompatible with version 7.8.0.
You need to add a callback for the skipping event; otherwise, the
playingAdstate won't change if the user clicks on the skip. (I'm not sure if we should add for other events too? )It seems there is a problem with your core library. so this line of code
player?.ads?.isPlaying?: falsedoesn't behave as experts. it seems it is always not null.the final output is like this:
Screen.Recording.2024-08-22.at.22.55.18.mov