[FEATURE] refactor LinkBrowserController fix from #510 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
opi99
approved these changes
Sep 20, 2023
|
@Mergifyio backport 8.1.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't test myself in pre-11, but the code is quite clear. The new solution resolves regressions with the LinkBrowser if the later is used e.g. in list module (changes were not transferred, same error TVP page module had, so we just traded one problem for another).
As requested in #510 (review):
Providing new variant for >=11 and retaining old solution for <=10
fixes #510, fixes #502, rels #503, rels #507, rels #508
backport 8.1.x