-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Linkbrowser fix #510
Conversation
Ok, understand, but could you rework this patch a bit? Do not delete the existing solution, as it works in TYPO3 v8 and yours only from TYPO3 v9 on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not delete the existing solution, as it works in TYPO3 v8 and yours only from TYPO3 v9 on.
So adding a version_compare() before XClassing and maybe. Would only take this for the 8.x branch and in the 11.x (main) branch adding the service variant.
Hi @opi99, I don't remember very well, but I think I didn't mention v.8 because I haven't tested the code in typo3 v.8 environment. Have you checked this in a typo3 v.8 environment? Unfortunately when I created this code I didn't have a v.8 to verify if everything was ok... |
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
[FEATURE] add new docker-compose free runTests.sh from EXT:tea [REGRESSION] pin composer-normalize to 2.28.3 to retain PHP7.4 compat [BUGFIX] Unhandled RuntimeException if DataStructure invalid fixes T3Voila#524 [FEATURE] refactor LinkBrowserController fix from T3Voila#510 providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
[FEATURE] refactor LinkBrowserController fix from #510
Closing in favor #528 |
[FEATURE] add new docker-compose free runTests.sh from EXT:tea [REGRESSION] pin composer-normalize to 2.28.3 to retain PHP7.4 compat [BUGFIX] Unhandled RuntimeException if DataStructure invalid fixes T3Voila#524 [FEATURE] refactor LinkBrowserController fix from T3Voila#510 providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
providing new for >=11 and retaining old solution for <=10 fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
A more robust approach that fixes item selection in linkbrowser.
This version will remove JavaScriptModuleInstruction xClass and just use only LinkBrowserController as xClass
ParentWindow is a new requireJS module which integrate only the getParent function in FormEngineLinkBrowserAdapter.
Compatible with typo3 9, 10, 11. Must be tested in v. 12.
LinkBrowserController is an xClass of ext:backend so you need to evaluate if the directory structure is correct or if you like having an xClass folder.
The file Configuration/Backend/Routes.php in the main branch should be used for all typo3 versions.
I think that this will definitely fix #509 #502 #451
I get inspired by the solution i found in FriendsOfTYPO3/frontend_editing#457 .
You can check it and FriendsOfTYPO3/frontend_editing#656 if you want to use a service instead of LinkBrowserController xclass.
In this case the code will be compatible only with typo3 version >= 11 because BootCompletedEventHandler is only defined by v.11