Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Linkbrowser fix #510

Closed
wants to merge 1 commit into from
Closed

Conversation

gregordonsky
Copy link
Contributor

A more robust approach that fixes item selection in linkbrowser.
This version will remove JavaScriptModuleInstruction xClass and just use only LinkBrowserController as xClass
ParentWindow is a new requireJS module which integrate only the getParent function in FormEngineLinkBrowserAdapter.
Compatible with typo3 9, 10, 11. Must be tested in v. 12.

LinkBrowserController is an xClass of ext:backend so you need to evaluate if the directory structure is correct or if you like having an xClass folder.

The file Configuration/Backend/Routes.php in the main branch should be used for all typo3 versions.

I think that this will definitely fix #509 #502 #451

I get inspired by the solution i found in FriendsOfTYPO3/frontend_editing#457 .
You can check it and FriendsOfTYPO3/frontend_editing#656 if you want to use a service instead of LinkBrowserController xclass.
In this case the code will be compatible only with typo3 version >= 11 because BootCompletedEventHandler is only defined by v.11

@opi99 opi99 added the Bug label Jul 30, 2023
@opi99 opi99 added this to the 8.1.4 milestone Jul 30, 2023
@opi99
Copy link
Collaborator

opi99 commented Jul 30, 2023

Ok, understand, but could you rework this patch a bit?

Do not delete the existing solution, as it works in TYPO3 v8 and yours only from TYPO3 v9 on.
So adding a version_compare() before XClassing and maybe. Would only take this for the 8.x branch and in the 11.x (main) branch adding the service variant.

@opi99 opi99 added the Question label Jul 30, 2023
Copy link
Collaborator

@opi99 opi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete the existing solution, as it works in TYPO3 v8 and yours only from TYPO3 v9 on.
So adding a version_compare() before XClassing and maybe. Would only take this for the 8.x branch and in the 11.x (main) branch adding the service variant.

@gregordonsky
Copy link
Contributor Author

Hi @opi99,

I don't remember very well, but I think I didn't mention v.8 because I haven't tested the code in typo3 v.8 environment.
I checked the typo3 v.8 source code and I think this patch should be compatible with this version as well.

Have you checked this in a typo3 v.8 environment? Unfortunately when I created this code I didn't have a v.8 to verify if everything was ok...

jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Aug 7, 2023
providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Aug 7, 2023
providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Aug 7, 2023
[FEATURE] add new docker-compose free runTests.sh from EXT:tea

[REGRESSION] pin composer-normalize to 2.28.3 to retain PHP7.4 compat

[BUGFIX] Unhandled RuntimeException if DataStructure invalid

fixes T3Voila#524

[FEATURE] refactor LinkBrowserController fix from T3Voila#510

providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Aug 9, 2023
providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
opi99 added a commit that referenced this pull request Sep 20, 2023
[FEATURE] refactor LinkBrowserController fix from #510
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
providing new for >=11 and retaining old solution for <=10

fixes #510, fixes #502, rels #503, rels #507, rels #508

(cherry picked from commit 7615160)
@opi99
Copy link
Collaborator

opi99 commented Sep 20, 2023

Closing in favor #528

@opi99 opi99 closed this Sep 20, 2023
opi99 added a commit that referenced this pull request Sep 20, 2023
[FEATURE] refactor LinkBrowserController fix from #510 (backport #528)
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Sep 20, 2023
[FEATURE] add new docker-compose free runTests.sh from EXT:tea

[REGRESSION] pin composer-normalize to 2.28.3 to retain PHP7.4 compat

[BUGFIX] Unhandled RuntimeException if DataStructure invalid

fixes T3Voila#524

[FEATURE] refactor LinkBrowserController fix from T3Voila#510

providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Sep 20, 2023
providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
jpmschuler added a commit to jpmschuler/templavoilaplus that referenced this pull request Sep 20, 2023
providing new for >=11 and retaining old solution for <=10

fixes T3Voila#510, fixes T3Voila#502, rels T3Voila#503, rels T3Voila#507, rels T3Voila#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkBrowser and canonical link
2 participants