-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose reading attempts in Plexon2 #3401
Merged
alejoe91
merged 9 commits into
SpikeInterface:main
from
h-mayorquin:expose_attempts_in_plexon2
Oct 18, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ce7338e
expose reading attempts
h-mayorquin 98cd18d
take into account neo version
h-mayorquin d047f78
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin bd06b6d
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin a4cc12e
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin ae5edd6
Update src/spikeinterface/extractors/neoextractors/plexon2.py
h-mayorquin 045874c
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin 9175fa1
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin 94ab456
Merge branch 'main' into expose_attempts_in_plexon2
h-mayorquin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to highlight that this is more common on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You think that would be helpful? if so, yes, by all means, can you make a suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I guess not. Since we are already forcing the tries (once Neo > 0.13.3 is out) then explaining when the failures occurs doesn't actually affect the user. Other than they could turn it down to 1, but it automatically only uses what it needs. So I changed my mind. I think this is good as is.