Expose reading attempts in Plexon2 #3401
Conversation
|
Ah, not release yet in neo, let me protect this so it is ready. |
| @@ -28,6 +28,10 @@ class Plexon2RecordingExtractor(NeoBaseRecordingExtractor): | |||
| ids: ["source3.1" , "source3.2", "source3.3", "source3.4"] | |||
| all_annotations : bool, default: False | |||
| Load exhaustively all annotations from neo. | |||
| readding_attemps : int, default: 25 | |||
| Number of attempts to read the file before raising an error | |||
| This opening process is somewhat unreliable and might fail occasionally. Adjust this higher | |||
There was a problem hiding this comment.
Do we want to highlight that this is more common on Linux.
There was a problem hiding this comment.
You think that would be helpful? if so, yes, by all means, can you make a suggestion?
There was a problem hiding this comment.
No I guess not. Since we are already forcing the tries (once Neo > 0.13.3 is out) then explaining when the failures occurs doesn't actually affect the user. Other than they could turn it down to 1, but it automatically only uses what it needs. So I changed my mind. I think this is good as is.
Co-authored-by: Zach McKenzie <[email protected]>
|
Weird test failure? Was the wrong info being bubbled up? Although it worked on Windows.... |
|
This is an environment issue. An older version of neo is being installed for some reason. |
|
@h-mayorquin the stream name in the test seem to be triggering an error. Can you check? |
It is what I mentioned to Zach I think Something in our CI is not installing neo dev! : O I will check it. |
|
We were missing the after-release. Fixed here #3440. |
|
This is ready. |
|
ok for me. |
We have been working on this neo, but I forgot to expose it here in Spikeinterface. It would be great if we could expose it here before the next patch release.