-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only assign memmap within boundaries for write_binary
#2796
Only assign memmap within boundaries for write_binary
#2796
Conversation
for more information, see https://pre-commit.ci
thanks. This is really cool. |
memmap_obj.flush() | ||
|
||
memmap_obj.close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this ?
the memmap_ojob is deleted no ?
This is a bit confusing because the file is stil open. Are we sure that this line do not close the underlying file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure but the file is not closed, otherwise the tests would not work.
Merci beaucoup beaucoup! |
This is like #1781 but for writing. I am writing the tutorial for how to use the job_kwargs and the memory heap reports crazy allocations for the following code:
Reason being that ta memmap for the whole array (80 GiB) is reserved even if it not used. A possible consequence of this massive heap allocation is that maybe the system will overswap. With the current PR this heap allocations disappears.
This will make my life easier for tracking the efficiency of processing and I think is a small increase in complexity.