Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload database script #6

Merged
merged 2 commits into from
May 24, 2024
Merged

Upload database script #6

merged 2 commits into from
May 24, 2024

Conversation

h-mayorquin
Copy link
Collaborator

To discuss and divide the computational load.

Copy link
Collaborator Author

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For us to discuss, @alejoe91 .

Two big points:

  1. Sometimes this is failing without Only assign memmap within boundaries for write_binary spikeinterface#2796. Sam seems OK with it, maybe we can ask him again and merge?
  2. I am wondering if now that are traversing the whole data with the analyzer we can also make an estimation of the noise.

python/upload_templates.py Outdated Show resolved Hide resolved
url = recording_asset.get_content_url(follow_redirects=True, strip_query=True)
file_path = url

electrical_series_path = "acquisition/ElectricalSeriesAp00"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alejoe91 I think this the 00 at the end of the path is restricting us to only one the two mounted probes? What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe we can use the find_electrical_series and add different AP streams as different datasets

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me test this.




ibl_recording = IblRecordingExtractor(pid=pid, stream_name=f"probe{probe_number}.ap" )
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alejoe91 this works and gets me what I expect but can you double check this?

python/upload_templates.py Outdated Show resolved Hide resolved
@alejoe91 alejoe91 merged commit cdca816 into main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants