Change result packaging to tar #130
Conversation
|
For the truncating test, the allowed filesize had to be increased, as tar has slightly larger overhead compared to zip and in the test that checks the results content, this had to be adapted to use tar as well |
src/command/execute_program.rs
Outdated
| .arg(out_path) | ||
| .arg("--junk-paths") | ||
| .arg("--exclude") |
There was a problem hiding this comment.
Why do we explicitly exclude "log"?
There was a problem hiding this comment.
My bad 😬 good catch, when zipping the --junk-paths option is actually used for not storing the directory name only
src/command/execute_program.rs
Outdated
| let path_to_res = format!("./archives/{}/results", res.program_id); | ||
| let result = format!("{}", res.timestamp); | ||
| let path_to_log = String::from("../../../data"); | ||
| let log = format!("{}_{}.log", res.program_id, res.timestamp); |
There was a problem hiding this comment.
Please use more self-explaining variable names (I know that it wasn't pretty previously either^^)
For strings that do not change, please use something like const SOME_NAME: &str = .... String::from creates a heap allocated string which incurs unneeded overhead.
src/command/execute_program.rs
Outdated
| .arg("-C") | ||
| .arg(path_to_res) | ||
| .arg(result) | ||
| .arg("-C") | ||
| .arg(path_to_log) | ||
| .arg(log) |
There was a problem hiding this comment.
I would prefer to have the file paths specified directly, i.e. without changing directories with -C, just to reduce the used strings a bit and make it more obvious what is included
florg-32
force-pushed
the
100-change-result-packaging-to-tar
branch
from
29beea3 to
d73e0b5
Compare
florg-32
force-pushed
the
100-change-result-packaging-to-tar
branch
from
d73e0b5 to
7b03a74
Compare
florg-32
force-pushed
the
100-change-result-packaging-to-tar
branch
from
7b03a74 to
4fce424
Compare
|
I resolved the before mentioned things, we might consider a mixed approach down the line, where we remove the path to the specific files, should we be desperate to save a few bytes. |
No description provided.