Refactor communication module #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florg-32
force-pushed
the
116-refactor-serial-communication
branch
from
d19d6bf to
45a26a7
Compare
florg-32
changed the title
florg-32
force-pushed
the
116-refactor-serial-communication
branch
from
7b878b1 to
6ae3b5e
Compare
This was
linked to
issues
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR majorly refactors the communication module. It replaces
rppalwithserialport-rsas the crate of choice and properly separates responsibilities in serial communication.Will be merged before #130
Closes #116, #105 and #131