Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S3749: Update rule description to add new javax and jakarta annotations (SONARJAVA-5036) #4578

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Modify rule S3749: Update rule description to add new javax and jakarta annotations (SONARJAVA-5036) #4578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79d63c
Update rule description to add javax persistence annotations and jaka…
erwan-serandour Dec 16, 2024
c2ba5d8
update after code review
erwan-serandour Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rules/S3749/java/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ This rule raises an issue when a singleton ``++@Component++``, ``++@Controller++
* ``++org.springframework.beans.factory.annotation.Value++``
* ``++javax.annotation.Inject++``
* ``++javax.annotation.Resource++``
* ``++javax.persistence.PersistenceContext++``
* ``++jakarta.persistence.PersistenceContext++``
* ``++jakarta.inject.Inject++``
* ``++jakarta.annotation.Resource++``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-order the elements so that they mirror the last above?

Suggested change
* ``++javax.persistence.PersistenceContext++``
* ``++jakarta.persistence.PersistenceContext++``
* ``++jakarta.inject.Inject++``
* ``++jakarta.annotation.Resource++``
* ``++javax.persistence.PersistenceContext++``
* ``++jakarta.annotation.Resource++``
* ``++jakarta.inject.Inject++``
* ``++jakarta.persistence.PersistenceContext++``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


== How to fix it

Expand Down
Loading