Modify rule S3749: Update rule description to add new javax and jakarta annotations (SONARJAVA-5036) #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rta inject and resource annotation
dorian-burihabwa-sonarsource
requested changes
Dec 16, 2024
rules/S3749/java/rule.adoc
Outdated
Comment on lines
11
to
14
| * ``++javax.persistence.PersistenceContext++`` | ||
| * ``++jakarta.persistence.PersistenceContext++`` | ||
| * ``++jakarta.inject.Inject++`` | ||
| * ``++jakarta.annotation.Resource++`` |
There was a problem hiding this comment.
Can we re-order the elements so that they mirror the last above?
Suggested change
| * ``++javax.persistence.PersistenceContext++`` | |
| * ``++jakarta.persistence.PersistenceContext++`` | |
| * ``++jakarta.inject.Inject++`` | |
| * ``++jakarta.annotation.Resource++`` | |
| * ``++javax.persistence.PersistenceContext++`` | |
| * ``++jakarta.annotation.Resource++`` | |
| * ``++jakarta.inject.Inject++`` | |
| * ``++jakarta.persistence.PersistenceContext++`` |
|
|
dorian-burihabwa-sonarsource
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: