Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-680 Modify S7131: Add vbnet #4511

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 14, 2024

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Create rule S7131 Modify rule S7131: Add vbnet Nov 14, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Modify rule S7131: Add vbnet NET-680 Modify S7131: Add vbnet Nov 15, 2024
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


[source,vbnet,diff-id=1,diff-type=noncompliant]
----
Public Class Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wau, so much VB and I have nothing to complain about!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And did you noticed how much nicer it looks compared to the C# bracket mess?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless CoPilot :P

I just added 2 new lines after that.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review November 15, 2024 16:44
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 831b770 into master Nov 15, 2024
9 of 10 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the rule/S7131-add-vbnet branch November 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants