Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7165: New Relic secrets should not be disclosed (APPSEC-2253) #4503

Merged
merged 5 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rules/S7165/metadata.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
}
56 changes: 56 additions & 0 deletions rules/S7165/secrets/metadata.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{
"title": "New Relic API keys should not be disclosed",
"type": "VULNERABILITY",
"code": {
"impacts": {
"SECURITY": "HIGH"
},
"attribute": "TRUSTWORTHY"
},
"status": "ready",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "30min"
},
"tags": [
"cwe",
"cert"
],
"defaultSeverity": "Blocker",
"ruleSpecification": "RSPEC-7165",
"sqKey": "S7165",
"scope": "All",
"securityStandards": {
"CWE": [
798,
259
],
"OWASP": [
"A3"
],
"CERT": [
"MSC03-J."
],
"OWASP Top 10 2021": [
"A7"
],
"PCI DSS 3.2": [
"6.5.10"
],
"PCI DSS 4.0": [
"6.2.4"
],
"ASVS 4.0": [
"2.10.4",
"3.5.2",
"6.4.1"
],
"STIG ASD_V5R3": [
"V-222642"
]
},
"defaultQualityProfiles": [
"Sonar way"
],
"quickfix": "unknown"
}
51 changes: 51 additions & 0 deletions rules/S7165/secrets/rule.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@

include::../../../shared_content/secrets/description.adoc[]

== Why is this an issue?

include::../../../shared_content/secrets/rationale.adoc[]

=== What is the potential impact?

If attackers gain access to a New Relic API key, they might be able to gain access to inject forged data,
to retrieve information potentially private or to configure features in New Relic monitoring solutions.
sebastien-andrivet-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

Below are some real-world scenarios that illustrate some impacts of an attacker
exploiting the secret..
sebastien-andrivet-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

include::../../../shared_content/secrets/impact/data_compromise.adoc[]

include::../../../shared_content/secrets/impact/data_modification.adoc[]

== How to fix it

include::../../../shared_content/secrets/fix/revoke.adoc[]

include::../../../shared_content/secrets/fix/recent_use.adoc[]

include::../../../shared_content/secrets/fix/vault.adoc[]

=== Code examples

:example_secret: NRAK-S6Z8F90IQDWRILXAKBBESCDIY99
sebastien-andrivet-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
:example_name: newrelic.api_key
:example_env: NEWRELIC_API_KEY

include::../../../shared_content/secrets/examples.adoc[]

//=== How does this work?

//=== Pitfalls

//=== Going the extra mile

== Resources

=== Documentation

* new relic Docs - https://docs.newrelic.com/docs/apis/intro-apis/new-relic-api-keys/[New Relic API keys]
* new relic Docs - https://docs.newrelic.com/docs/synthetics/synthetic-monitoring/private-locations/private-locations-overview-monitor-internal-sites-add-new-locations/[Private locations overview: Monitor internal sites and add new locations]

include::../../../shared_content/secrets/resources/standards.adoc[]

//=== Benchmarks
Loading