Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7165: New Relic secrets should not be disclosed (APPSEC-2253) #4503

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Create rule S7165 Create rule S7165: Relic secrets should not be disclosed (APPSEC-2253) Nov 14, 2024
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource changed the title Create rule S7165: Relic secrets should not be disclosed (APPSEC-2253) Create rule S7165: New Relic secrets should not be disclosed (APPSEC-2253) Nov 14, 2024
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text needs minor improvements before merge, else LGTM

rules/S7165/secrets/rule.adoc Outdated Show resolved Hide resolved
rules/S7165/secrets/rule.adoc Outdated Show resolved Hide resolved
rules/S7165/secrets/rule.adoc Show resolved Hide resolved
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource marked this pull request as ready for review November 15, 2024 15:09
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource merged commit 470973e into master Nov 15, 2024
9 of 10 checks passed
@sebastien-andrivet-sonarsource sebastien-andrivet-sonarsource deleted the rule/add-RSPEC-S7165 branch November 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants