fix: set fg url in rollup.json #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap2pecs
reviewed
Nov 14, 2024
scripts/l2/l2-op-node-restart.sh
Outdated
| @@ -15,6 +15,24 @@ docker compose -f docker/docker-compose-l2.yml stop op-node | |||
| # set L2OO or DGF env vars | |||
| post_deployment_setup_env_vars $(pwd)/.deploy/op-devnet-deployments-${L2_CHAIN_ID}.json $DEVNET_L2OO | |||
|
|
|||
| ROLLUP_CONFIG=$(pwd)/.deploy/rollup.json | |||
| # set babylonFinalityGadgetRpc in rollup.json | |||
| if [ "$BBN_FINALITY_GADGET_RPC" != "" ]; then | |||
There was a problem hiding this comment.
actually we don't need this check at all
l2-op-node-restart.sh should support case where we want to disable FG
i.e. setting it from non-empty to empty
we just override whatever it has in the .env to rollup.json
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a step to set the
babylonFinalityGadgetRpcin rollup.json with the env var when restarting op-nodeTest Plan
TODO: it will be tested on new deployment