Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fg url #41

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: update fg url #41

merged 1 commit into from
Nov 20, 2024

Conversation

lesterli
Copy link
Member

@lesterli lesterli commented Nov 20, 2024

Summary

This PR fixes an issue from the previous PR #38 where the wrong key was used. It should be babylon_finality_gadget_rpc instead of babylonFinalityGadgetRpc in the rollup.json file.

Test Plan

first comment out the lines 13, 16, 38, run the script and check the rollup.json

make l2-op-node-restart

set BBN_FINALITY_GADGET_RPC= in .env, it should be "babylon_finality_gadget_rpc": "" in rollup.json, and output:

Stopping the OP Node...
Setting babylon_finality_gadget_rpc with empty value in rollup.json
Starting the OP Node...

set BBN_FINALITY_GADGET_RPC=11.22.33.44:50051 in .env, it should be "babylon_finality_gadget_rpc": "11.22.33.44:50051" in rollup.json, and output:

Stopping the OP Node...
Setting babylon_finality_gadget_rpc with value 11.22.33.44:50051 in rollup.json
Starting the OP Node...

Note: Revert the commented out lines

@lesterli lesterli requested a review from a team as a code owner November 20, 2024 12:40
@lesterli lesterli merged commit 8348bd5 into main Nov 20, 2024
1 check passed
@lesterli lesterli deleted the fix/update-fg-url branch November 20, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants